Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

split LDAP filters #399

Merged
merged 2 commits into from
Jul 27, 2020
Merged

split LDAP filters #399

merged 2 commits into from
Jul 27, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 24, 2020

  • Update reva to v0.1.1-0.20200724
  • Update LDAP filters

With the separation of use and find filters we can now use a filter that taken into account a users uuid as well as his username. This is necessary to make sharing work with the new account service which assigns accounts an immutable account id that is different from the username. Furthermore, the separate find filters now allows searching users by their displayname or email as well.

userfilter = "(&(objectclass=posixAccount)(|(ownclouduuid={{.OpaqueId}})(cn={{.OpaqueId}})))"
findfilter = "(&(objectclass=posixAccount)(|(cn={{query}}*)(displayname={{query}}*)(mail={{query}}*)))"

@butonic butonic self-assigned this Jul 24, 2020
@butonic butonic marked this pull request as draft July 24, 2020 08:58
@butonic butonic added the bug Something isn't working label Jul 24, 2020
@butonic butonic requested review from kulmann and refs July 24, 2020 08:58
@butonic butonic force-pushed the split-ldap-filters branch 2 times, most recently from 45d8658 to d23a209 Compare July 24, 2020 14:16
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the split-ldap-filters branch from d23a209 to 15de954 Compare July 24, 2020 14:22
@butonic butonic marked this pull request as ready for review July 24, 2020 14:22
@IljaN IljaN self-requested a review July 24, 2020 14:55
Copy link
Contributor

@IljaN IljaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works with owncloud storage with 6g file

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

Well, tests are failing... we have to look into that 🤷 but manual check in UI (also with owncloud storage) worked.

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- pkg/command/users.go  1
- pkg/command/authbasic.go  1
         

See the complete overview on Codacy

@butonic butonic merged commit 5e5ae35 into owncloud:master Jul 27, 2020
@butonic butonic deleted the split-ldap-filters branch July 27, 2020 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants