Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

allow different namespaces #77

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Feb 4, 2020

after fbf131c the path for the "new" webdav path does not contain a username /remote.php/dav/files/textfile0.txt it used to be /remote.php/dav/files/oc/einstein/textfile0.txt
So it lost oc/einstein

This PR allows setting up different namespaces for /webav and /dav/files:

  • /webdav is jailed into /home - which uses the home storage driver and uses the logged in user to construct the path
  • /dav/files is jailed into /oc - which uses the owncloud storage driver and expects a username as the first path segment

this mimics oc10

related: #68

  • update CHANGELOG

Sorry, something went wrong.

@update-docs
Copy link

update-docs bot commented Feb 4, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic self-assigned this Feb 4, 2020
@butonic butonic added the bug Something isn't working label Feb 4, 2020
@butonic
Copy link
Member Author

butonic commented Feb 4, 2020

@individual-it this changes what the api tests see, but also finally better mimic what oc10 does.

@dpakach
Copy link
Contributor

dpakach commented Feb 5, 2020

@butonic even with the new URLs https://github.com/owncloud/ocis-reva/issues/9 still exists. Is this the expected behavior or not?
I have adjusted the aceeptance tests in core (owncloud/core#36884). Tested successfully at #79
Once the core PR gets merged in core you can remove

'WEBDAV_NAMESPACE_JAIL': '/'
this line. That should work.

@butonic
Copy link
Member Author

butonic commented Feb 5, 2020

#9 is about acls not preventing access, which is still a bug. I'll modify .drone.star in the break.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the allow_different_namespaces branch from 883427c to a3a4232 Compare February 5, 2020 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants