Merge pull request #1388 from ishank011/roles-fix

Check if roles are present in user object before looking those up
owncloud · Jan 29, 2021 · 1b9126a · 1b9126a
2 parents 4fa7366 + 30c80b0
commit 1b9126a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/changelog/unreleased/account-roles-fix.md b/changelog/unreleased/account-roles-fix.md
@@ -0,0 +1,3 @@
+Bugfix: Check if roles are present in user object before looking those up
+
+https://github.com/owncloud/ocis/pull/1388
diff --git a/ocis-pkg/middleware/account.go b/ocis-pkg/middleware/account.go
@@ -67,7 +67,11 @@ func ExtractAccountUUID(opts ...account.Option) func(http.Handler) http.Handler
 			ctx = context.WithValue(ctx, UUIDKey, u.Id.OpaqueId)
 			// TODO: implement token manager in cs3org/reva that uses generic metadata instead of access token from header.
 			ctx = metadata.Set(ctx, AccountID, u.Id.OpaqueId)
-			ctx = metadata.Set(ctx, RoleIDs, string(u.Opaque.Map["roles"].Value))
+			if u.Opaque != nil {
+				if roles, ok := u.Opaque.Map["roles"]; ok {
+					ctx = metadata.Set(ctx, RoleIDs, string(roles.Value))
+				}
+			}
 			next.ServeHTTP(w, r.WithContext(ctx))
 		})
 	}