Merge pull request #6259 from 2403905/issue-5431

Omitempty givenName attribute when create user #5431
owncloud · May 10, 2023 · 21dfe2d · 21dfe2d
2 parents 1c0e318 + 11e51b9
commit 21dfe2d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/changelog/unreleased/fix-omitempty-givenName.md b/changelog/unreleased/fix-omitempty-givenName.md
@@ -0,0 +1,6 @@
+Bugfix: Fix the empty string givenName attribute when creating user
+
+Omitempty givenName attribute when creating user
+
+https://github.com/owncloud/ocis/issues/5431
+https://github.com/owncloud/ocis/pull/6259
diff --git a/services/graph/pkg/identity/ldap.go b/services/graph/pkg/identity/ldap.go
@@ -784,7 +784,6 @@ func (i *LDAP) createUserModelFromLDAP(e *ldap.Entry) *libregraph.User {
 	if err != nil {
 		i.logger.Warn().Str("dn", e.DN).Str(i.userAttributeMap.id, e.GetAttributeValue(i.userAttributeMap.id)).Msg("Invalid User. Cannot convert UUID")
 	}
-	givenName := e.GetEqualFoldAttributeValue(i.userAttributeMap.givenName)
 	surname := e.GetEqualFoldAttributeValue(i.userAttributeMap.surname)
 
 	if id != "" && opsan != "" {
@@ -793,7 +792,7 @@ func (i *LDAP) createUserModelFromLDAP(e *ldap.Entry) *libregraph.User {
 			Mail:                     pointerOrNil(e.GetEqualFoldAttributeValue(i.userAttributeMap.mail)),
 			OnPremisesSamAccountName: &opsan,
 			Id:                       &id,
-			GivenName:                &givenName,
+			GivenName:                pointerOrNil(e.GetEqualFoldAttributeValue(i.userAttributeMap.givenName)),
 			Surname:                  &surname,
 			UserType:                 pointerOrNil(e.GetEqualFoldAttributeValue(i.userAttributeMap.userType)),
 			AccountEnabled:           booleanOrNil(e.GetEqualFoldAttributeValue(i.userAttributeMap.accountEnabled)),

diff --git a/services/graph/pkg/identity/ldap_test.go b/services/graph/pkg/identity/ldap_test.go
@@ -308,6 +308,7 @@ func TestUpdateUser(t *testing.T) {
 		displayName              string
 		onPremisesSamAccountName string
 		accountEnabled           *bool
+		givenName                *string
 		userType                 *string
 	}
 	type args struct {
@@ -1441,7 +1442,7 @@ func TestUpdateUser(t *testing.T) {
 					DisplayName:              &tt.want.displayName,
 					OnPremisesSamAccountName: &tt.want.onPremisesSamAccountName,
 					Surname:                  &emptyString,
-					GivenName:                &emptyString,
+					GivenName:                tt.want.givenName,
 					UserType:                 tt.want.userType,
 				}