Merge pull request #2118 from owncloud/graph-explorer-client-registra…

…tion properly configure the graph-explorer openid connect client
owncloud · Jun 10, 2021 · 7062b43 · 7062b43
2 parents fd8b3d2 + 68079b7
commit 7062b43
Show file tree

Hide file tree

Showing 3 changed files with 103 additions and 64 deletions.
diff --git a/changelog/unreleased/graph-explorer-openid-connect.md b/changelog/unreleased/graph-explorer-openid-connect.md
@@ -0,0 +1,5 @@
+Enhancement: Properly configure graph-explorer client registration
+
+The client registration in the `identifier-registration.yaml` for the graph-explorer didn't contain `redirect_uris` nor `origins`. Both were added to prevent exploitation.
+
+https://github.com/owncloud/ocis/pull/2118
diff --git a/idp/assets/identifier-registration.yaml b/idp/assets/identifier-registration.yaml
@@ -14,6 +14,11 @@ clients:
   - id: ocis-explorer.js
     name: oCIS Graph Explorer
     trusted: yes
+    redirect_uris:
+      - {{OCIS_URL}}/graph-explorer/
+    origins:
+      - {{OCIS_URL}}
+
 
   - id: xdXOt13JKxym1B1QcEncf2XDkLAexMBFwiT9j6EfhhHFJhs2KM9jbjTmf8JBXE69
     secret: UBntmLjC2yYCeHwsyj73Uwo9TAaecAetRwMw0xYcvNL9yRdLSUi0hUAHfvCHFeFh