Skip to content

Commit

Permalink
Merge pull request #4133 from wkloucek/fix-ocis-run-services
Browse files Browse the repository at this point in the history
fix `OCIS_RUN_SERVICES`
  • Loading branch information
phil-davis committed Jul 7, 2022
2 parents af1a29d + ab960dc commit bcdbaa1
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions changelog/unreleased/fix-ocis-run-services.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Bugfix: Fix `OCIS_RUN_SERVICES`

`OCIS_RUN_SERVICES` was introduced as successor to `OCIS_RUN_EXTENSIONS` because
we wanted to call oCIS "core" extensions services. We kept `OCIS_RUN_EXTENSIONS` for
backwards compatibility reasons.

It turned out, that setting `OCIS_RUN_SERVICES` has no effect since introduced. `OCIS_RUN_EXTENSIONS`.
`OCIS_RUN_EXTENSIONS` was working fine all the time.

We now fixed `OCIS_RUN_SERVICES`, so that you can use it as a equivalent replacement for `OCIS_RUN_EXTENSIONS`

https://github.com/owncloud/ocis/pull/4133
2 changes: 1 addition & 1 deletion ocis-pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type Mode int
type Runtime struct {
Port string `yaml:"port" env:"OCIS_RUNTIME_PORT"`
Host string `yaml:"host" env:"OCIS_RUNTIME_HOST"`
Extensions string `yaml:"services" env:"OCIS_RUN_EXTENSIONS,OCIS_RUN_SERVICES"`
Extensions string `yaml:"services" env:"OCIS_RUN_EXTENSIONS;OCIS_RUN_SERVICES"`
}

// Config combines all available configuration parts.
Expand Down

0 comments on commit bcdbaa1

Please sign in to comment.