Skip to content

Commit

Permalink
address reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
@SwikritiT
SwikritiT committed Aug 31, 2022
1 parent 4e4948e commit f274752
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 31 deletions.
55 changes: 27 additions & 28 deletions tests/acceptance/features/apiSpaces/shareOperations.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: sharing
| username |
| Alice |
| Brian |
And using spaces DAV path
And using spaces DAV path


Scenario: Correct webdav share-permissions for received file with edit and reshare permissions
Expand Down Expand Up @@ -73,7 +73,7 @@ Feature: sharing
| permissions | share,read |
Then the HTTP status code should be "200"
And as user "Brian" file "/tmp.txt" inside space "Shares Jail" should contain a property "ocs:share-permissions" with value "17"


Scenario: Correct webdav share-permissions for received group shared file with reshare permissions but no edit permissions
Given group "grp1" has been created
Expand Down Expand Up @@ -101,7 +101,7 @@ Feature: sharing
| ocs:share-permissions |
Then the HTTP status code should be "207"
And the single response should contain a property "ocs:share-permissions" with value "31"


Scenario: Correct webdav share-permissions for received group shared folder with all permissions
Given group "grp1" has been created
Expand Down Expand Up @@ -144,7 +144,7 @@ Feature: sharing
| ocs:share-permissions |
Then the HTTP status code should be "207"
And the single response should contain a property "ocs:share-permissions" with value "29"


Scenario: Correct webdav share-permissions for received folder with all permissions but create
Given user "Alice" has created folder "/tmp"
Expand All @@ -154,7 +154,7 @@ Feature: sharing
| permissions | share,delete,update,read |
Then the HTTP status code should be "200"
And as user "Brian" folder "/tmp" inside space "Shares Jail" should contain a property "ocs:share-permissions" with value "27"


Scenario: Correct webdav share-permissions for received group shared folder with all permissions but create
Given group "grp1" has been created
Expand All @@ -171,7 +171,7 @@ Feature: sharing
| ocs:share-permissions |
Then the HTTP status code should be "207"
And the single response should contain a property "ocs:share-permissions" with value "27"


Scenario: Correct webdav share-permissions for received folder with all permissions but delete
Given user "Alice" has created folder "/tmp"
Expand All @@ -181,8 +181,8 @@ Feature: sharing
| permissions | share,create,update,read |
Then the HTTP status code should be "200"
And as user "Brian" folder "/tmp" inside space "Shares Jail" should contain a property "ocs:share-permissions" with value "23"


Scenario: Correct webdav share-permissions for received group shared folder with all permissions but delete
Given group "grp1" has been created
And user "Brian" has been added to group "grp1"
Expand All @@ -198,7 +198,7 @@ Feature: sharing
| ocs:share-permissions |
Then the HTTP status code should be "207"
And the single response should contain a property "ocs:share-permissions" with value "23"


Scenario: Correct webdav share-permissions for received folder with all permissions but share
Given user "Alice" has created folder "/tmp"
Expand All @@ -208,7 +208,7 @@ Feature: sharing
| permissions | change |
Then the HTTP status code should be "200"
And as user "Brian" folder "/tmp" inside space "Shares Jail" should contain a property "ocs:share-permissions" with value "15"


Scenario: Correct webdav share-permissions for received group shared folder with all permissions but share
Given group "grp1" has been created
Expand Down Expand Up @@ -240,8 +240,8 @@ Feature: sharing
When user "Brian" uploads a file inside space "Shares Jail" with content "new description" to "/FOLDER/textfile.txt" using the WebDAV API
Then the HTTP status code should be "403"
And as "Alice" file "/FOLDER/textfile.txt" should not exist


Scenario: Uploading a file to a folder received as a upload-only user share
Given user "Alice" has created folder "FOLDER"
And user "Alice" has created a share with settings
Expand Down Expand Up @@ -277,7 +277,7 @@ Feature: sharing
And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:
"""
new description
"""
"""


Scenario: Uploading a file to a folder received as a read/write user share
Expand All @@ -293,7 +293,7 @@ Feature: sharing
And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:
"""
new description
"""
"""


Scenario: Uploading a file to a folder received as a read/write group share
Expand All @@ -311,12 +311,11 @@ Feature: sharing
And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:
"""
new description
"""
"""


Scenario: Check quota of owners parent directory of a shared file
Given user "Admin" has changed the quota of the "Brian Murphy" space to "1"
And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/myfile.txt"
Given user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/myfile.txt"
And user "Alice" has shared file "myfile.txt" with user "Brian"
And user "Brian" has accepted share "/myfile.txt" offered by user "Alice"
When user "Brian" uploads a file inside space "Shares Jail" with content "new description" to "/myfile.txt" using the WebDAV API
Expand All @@ -337,12 +336,12 @@ Feature: sharing
| permissions | change |
| shareWith | Brian |
And user "Brian" has accepted share "/FOLDER" offered by user "Alice"
And user "Admin" has changed the quota of the "Alice Hansen" space to "1"
And user "Admin" has changed the quota of the personal space of "Alice Hansen" space to "1"
When user "Brian" uploads a file inside space "Shares Jail" with content "new description" to "/FOLDER/textfile.txt" using the WebDAV API
Then the HTTP status code should be "507"
And as "Alice" file "/FOLDER/textfile.txt" should not exist


Scenario: Uploading to a user shared folder with upload-only permission when the sharer has insufficient quota
Given user "Alice" has created folder "FOLDER"
And user "Alice" has created a share with settings
Expand All @@ -351,12 +350,12 @@ Feature: sharing
| permissions | create |
| shareWith | Brian |
And user "Brian" has accepted share "/FOLDER" offered by user "Alice"
And user "Admin" has changed the quota of the "Alice Hansen" space to "1"
And user "Admin" has changed the quota of the personal space of "Alice Hansen" space to "1"
When user "Brian" uploads a file inside space "Shares Jail" with content "new description" to "/FOLDER/textfile.txt" using the WebDAV API
Then the HTTP status code should be "507"
And as "Alice" file "/FOLDER/textfile.txt" should not exist


Scenario: Uploading a file to a group shared folder with upload-only permission when the sharer has insufficient quota
Given group "grp1" has been created
And user "Brian" has been added to group "grp1"
Expand All @@ -367,12 +366,12 @@ Feature: sharing
| permissions | create |
| shareWith | grp1 |
And user "Brian" has accepted share "/FOLDER" offered by user "Alice"
And user "Admin" has changed the quota of the "Alice Hansen" space to "10"
And user "Admin" has changed the quota of the personal space of "Alice Hansen" space to "10"
When user "Brian" uploads a file inside space "Shares Jail" with content "new descriptionfgshsywhhh" to "/FOLDER/textfile.txt" using the WebDAV API
Then the HTTP status code should be "507"
And as "Alice" file "/FOLDER/textfile.txt" should not exist
And as "Alice" file "/FOLDER/textfile.txt" should not exist



Scenario Outline: Sharer can download file uploaded with different permission by sharee to a shared folder
Given user "Alice" has created folder "FOLDER"
And user "Alice" has created a share with settings
Expand All @@ -384,8 +383,8 @@ Feature: sharing
When user "Brian" uploads a file inside space "Shares Jail" with content "some content" to "/FOLDER/textfile.txt" using the WebDAV API
And user "Alice" downloads file "/FOLDER/textfile.txt" using the WebDAV API
Then the HTTP status code should be "200"
And the downloaded content should be "some content"
And the downloaded content should be "some content"
Examples:
| permissions |
| change |
| create |
| create |
6 changes: 3 additions & 3 deletions tests/acceptance/features/bootstrap/SpacesContext.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ public function listAllSpacesRequest(
array $headers = []
): ResponseInterface {
$fullUrl = $this->baseUrl . "/graph/v1.0/drives/" . $urlArguments;

return HttpRequestHelper::get($fullUrl, $xRequestId, $user, $password, $headers, $body);
}

Expand Down Expand Up @@ -1702,7 +1702,7 @@ public function updateSpaceQuota(
}

/**
* @Given /^user "([^"]*)" has changed the quota of the "([^"]*)" space to "([^"]*)"$/
* @Given /^user "([^"]*)" has changed the quota of the personal space of "([^"]*)" space to "([^"]*)"$/
*
* @param string $user
* @param string $spaceName
Expand Down Expand Up @@ -1814,7 +1814,7 @@ public function sendUpdateSpaceRequest(
): ResponseInterface {
$fullUrl = $this->baseUrl . "/graph/v1.0/drives/$spaceId";
$method = 'PATCH';

return HttpRequestHelper::sendRequest($fullUrl, $xRequestId, $method, $user, $password, $headers, $body);
}

Expand Down

0 comments on commit f274752

Please sign in to comment.