Configure default write location

[refs]

Currently konnectd's default writes a private key and a self signed certificate to the binary running location, leaving the programmer to either exclude this files from the git tree or in general adding some noise. If this is intended only for development we can use a tmp dir

[refs]

cc @IljaN @butonic

[IljaN]

Yes the current implementation is not ideal. For the certs temp-dir would be okay 👍

But we are also creating default config-files. Need to do more concepting. A better approach would be to commit required default-configs to the configs dir. But this would break the current zero-configuration approach i.e just run the binary.

A counter-point would be that the binary will always be delivered in a tar anyways so we can also ship the config dir with it.

[IljaN]

Currently ocis-konnectd is doing the writing. But lets leave the issue here, as this might concern other services as well in the future.

[refs]

or delete generated artifacts on shutdown

[IljaN]

Okay I realize now that it polutes the config dir in the code-tree. Didn't think about this case because I always run the binary with ocis/bin as $PWD.

Would a .gitignore entry be okay for a start? But then we need to add files to ocis .gitignore which belong to other repos (ocis-konnectd) 🤔.

or delete generated artifacts on shutdown

This would work for developers but on a production system we probably won't have the permission to create anything in $PWD at all. Assuming configs are in /etc and the binary in /usr/bin or similar.

[IljaN]

IIRC other high-profile golang projects createe a directory in $XDG_CONFIG_HOME unless a flag overrides this behaviour. This would cover both use-cases i.e running in development or testing vs running as daemon.

See: https://wiki.archlinux.org/index.php/XDG_Base_Directory

[refs]

or just add it to your global gitignore

[IljaN]

or just add it to your global .gitignore

Then every developer needs to remember to do it. Bad DX ;)

IMO using the XDG standard would be the right approach. What do you think?

[IljaN]

IMO using the XDG standard would be the right approach. What do you think?

Hmhh... but this would break windows and osx builds. So we would need to have an os-specific abstraction for it.
https://stackoverflow.com/questions/3373948/equivalents-of-xdg-config-home-and-xdg-data-home-on-mac-os-x

[refs]

...I was in the process of typing this down :D

[refs]

In theory the accounts / settings service should account for storing any configuration parameter, a private key and cert counts as that I guess.

[IljaN]

@refs look what I`ve found:
https://github.com/ProtonMail/go-appdir
https://github.com/kirsle/configdir ;)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[refs]

IMHO this is a super easy quick win @micbar

[micbar]

Super easy quick fix for me would be more like effort 1 or 3 😄

[refs]

@micbar #2129

[refs]

@IljaN https://golang.org/pkg/os/#UserConfigDir