Show username in collaborators/share tab

[butonic]

ocis.owncloud.works does not show the email or username in the list of recipients.

[refs]

@butonic can you be more specific? Where exactly? :)

[exalate-issue-sync]

Willy Kloucek commented: I guess here:

If you have it shared with two "Max Mustermann" you should be able to distinguish between them.

[butonic]

Hm this should be working as of nov last year: owncloud/web#4203, but I cannot see the email on demo.owncloud.com when trying to find recipients or when accepting shares ... 🤔 @kulmann @LukasHirt any idea?

[LukasHirt]

but I cannot see the email on demo.owncloud.com when trying to find recipients or when accepting shares

@butonic Check if it's enabled in the settings. Admin -> Sharing -> Extra field to display in autocomplete results. When it's enabled, I can see it just fine:

[kulmann]

ownCloud Web simply renders whatever value shareWithAdditionalInfo of a sharee holds.
Doing a quick git grep "shareWithAdditionalInfo" in the reva and ocis repo shows 0 results.

See relevant ownCloud 10 code here:
https://github.com/owncloud/core/blob/39b3dd7627465eb316d1b707bd21cb0b6b3c972e/apps/files_sharing/lib/Controller/ShareesController.php#L206
https://github.com/owncloud/core/blob/39b3dd7627465eb316d1b707bd21cb0b6b3c972e/apps/files_sharing/lib/Controller/ShareesController.php#L278

[butonic]

fix landed in ocis master with #1588

[labkode]

Can we have it configurable? choose between username and mail. Maybe have a template? like storage user layout?

[labkode]

@butonic

[butonic]

currently hardcoded to email, needs to be made configurable to at least username or email. best would be a template.

[labkode]

Same template mechanism we use for the storage layout, that would be great

[labkode]

@butonic when you're back let's catch up on this

[ishank011]

Done cs3org/reva#1588

[pascalwengerter]

What's the status quo on this one?

[ishank011]

@pascalwengerter this can be closed