Make additional info attribute configureable #1588
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ishank011
force-pushed
the
share-additional-info
branch
from
73f8c52
to
8aa4bec
Compare
|
@ishank011 can you make it configurable with a layout like we do for the home configuration, for example: |
ishank011
force-pushed
the
share-additional-info
branch
from
1bc2925
to
46473dc
Compare
|
@labkode done |
ishank011
force-pushed
the
share-additional-info
branch
from
46473dc
to
8652dbf
Compare
ishank011
force-pushed
the
share-additional-info
branch
from
1948226
to
bb4f89d
Compare
| @@ -73,6 +76,8 @@ func (h *Handler) Init(c *config.Config) error { | |||
| h.sharePrefix = c.SharePrefix | |||
| h.homeNamespace = c.HomeNamespace | |||
|
|
|||
| h.additionalInfoTemplate, _ = template.New("additionalInfo").Parse(c.AdditionalInfoAttribute) | |||
There was a problem hiding this comment.
Are you not checking the error here because the only way it could fail is if the template has already been parsed? Otherwise, I think there is some value in error checking here, at least for debugging purposes.
There was a problem hiding this comment.
@refs I thought that we shouldn't fatal if the parsing fails. Similarly, in case executing the template fails, I didn't report an error but returned an empty string. I'll add a warning there
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
Show resolved
Hide resolved
No description provided.