Support for favorites

[PVince81]

Add support for favorite APIs in ocis.

Currently in OCIS the favorites information is already stored in the storage arbitrary metadata.
We should also implement the Webdav API (I believe it was a REPORT endpoint) for retrieving all favorites across all storages. This will require implementing some lookup cache to avoid having to traverse all storage trees to find the favorites.

@butonic @pmaier1 FYI

[PVince81]

In #354 we'll add a capability, so we'll need to enable it once favorites are fully implemented.

• implement REPORT API for populating the UI list under the "Favorites" section
• enable capability
• enable tests

[pascalwengerter]

@individual-it can we close #724 and #1263 in favor of this issue (which provides the context of communicating favorites inside the capabilities)? We're hiding it on the frontend right now (based on capabilities) and I guess the tests for it are in expected failures?

[kulmann]

In #354 we'll add a capability, so we'll need to enable it once favorites are fully implemented.

• implement REPORT API for populating the UI list under the "Favorites" section
• enable capability
• enable tests

This still reflects the current state. I enabled the files.favorites capability in oCIS last week (locally). The following happens:

• I can add and remove files to/from favorites, state gets persisted and loaded correctly (at least with oCIS storage driver)
• the REPORT request for listing all favorites is not implemented, so the Favorites view doesn't work.

The list stated by Vincent is still valid. REPORT request for favorites needs to be implemented.

[pascalwengerter]

@C0rby what's the current status here? :)

[butonic]

• use search to provide lookup for favorites?
• needs to add favorite to index
• option 1: use a custom favorites manager
• option 2: use events
  • hmm favorites would be a separate per user index, not a per space index because favorites cross space boundaries and the 'favorite flag' is per user ... not per file
• option 3: add to expected failures for now

[individual-it]

I believe the tests are already in the expected failures file
https://github.com/owncloud/ocis/blob/0db6fae3ad4a48cd1ad1e3a68a0119b52d24f152/tests/acceptance/expected-failures-API-on-OCIS-storage.md#report-request-not-implemented (search and favorites)

[micbar]

the core api tests in ocis are now using a new file https://github.com/owncloud/ocis/blob/master/tests/acceptance/expected-failures-graphAPI-on-OCIS-storage.md

[butonic]

favorites REPORT was implemented in cs3org/reva#2086

• add persistence layer other than in memory

[diocas]

This ticket is still open but I suppose the functionality has been provided so it could be closed?

But I just found out that there's a conflict between the REPORT used by the favorites and the REPORT used by the new search functionality... If web requests favorites, the backend fails with missing search-files tag.

Do you want me to open a new ticket or we follow here?

[micbar]

The REPORT for ocis is not yet implemented. In reva, we have the Favorites Manager. There are currently two implementations: cbox(mysql) and memory. For ocis we need a new persistent implementation.

@fschade FYI

[fschade]

Please open again if the ticket is still relevant

[kulmann]

Yes, still relevant. We want to have the favorites feature in oCIS. The web UI has everything we need already done from the oc10 implementation. The oCIS backend also already has everything we need (favorites state in file metadata, REPORT webdav request for listing favorites), but it only has an in memory implementation for storing the favorites index. The favorites index needs to be persisted.

[fschade]

thanks, i add the housekeeping label for the moment, then we can discuss those older issues and plan hot to proceed.
SRY for closing, but we have to start somewhere :)

[saw-jan]

Currently when enabling favorites (FRONTEND_ENABLE_FAVORITES=true), then request returns 400 Bad Request

curl -XREPORT https://localhost:9200/remote.php/dav/files/admin
-d'<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:prop>
    <oc:permissions/>
    ...
  </d:prop>
  <oc:filter-rules>
    <oc:favorite>1</oc:favorite>
  </oc:filter-rules>
</oc:filter-files>'
-uadmin:admin -vk

400 Bad Request

<?xml version="1.0" encoding="UTF-8"?>
<d:error xmlns:d="DAV" xmlns:s="http://sabredav.org/ns">
	<s:exception>Sabre\DAV\Exception\BadRequest</s:exception>
	<s:message>missing search-files tag</s:message>
</d:error>