Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial version of the search extension #3635

Merged
merged 56 commits into from
May 2, 2022
Merged

Conversation

aduffeck
Copy link
Contributor

Description

This pr adds the new search extension which indexes files and directories and makes them searchable using the search service from within the web UI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

aduffeck and others added 30 commits April 8, 2022 10:53
It's still incomplete and isn't working yet.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@update-docs
Copy link

update-docs bot commented Apr 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic mentioned this pull request Apr 29, 2022
45 tasks
aduffeck and others added 5 commits April 29, 2022 15:23
@butonic
Copy link
Member

butonic commented May 2, 2022

file names are indexed and show up in search results on the API, the web ui/owncloudsdk still filters them though and it seems folder are not indexed, yet. still, the PoC works!

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-1 failed. Further test are cancelled...

@butonic
Copy link
Member

butonic commented May 2, 2022

runsh: Total unexpected failed scenarios throughout the test run:
apiFavorites/favorites.feature:115
apiFavorites/favorites.feature:116
apiFavorites/favorites.feature:141
apiFavorites/favorites.feature:142
apiFavorites/favorites.feature:267
apiFavorites/favorites.feature:268

fail because the proxy would have to route REPORT requests to /remote.php/dav based on the body:

  • reva ocdav implements favorites
  • ocis webdav implements search

@butonic
Copy link
Member

butonic commented May 2, 2022

  • use search to provide lookup for favorites?
  • needs to add favorite to index
    • option 1: use a custom favorites manager
    • option 2: use events
    • option 3: add to expected failures for now

tracked in #1228

butonic and others added 3 commits May 2, 2022 16:00
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 48 Code Smells

1.2% 1.2% Coverage
7.9% 7.9% Duplication

@butonic butonic merged commit 1c8b353 into owncloud:master May 2, 2022
ownclouders pushed a commit that referenced this pull request May 2, 2022
Merge: ea08dc9 fd4ec56
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Mon May 2 19:25:07 2022 +0200

    Merge pull request #3635 from aduffeck/search

    Add initial version of the search extension
@butonic butonic deleted the search branch May 2, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants