allow proxy to route based on request method #3526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
proxy-method-routing
branch
2 times, most recently
from
01d1a4b
to
2bee87b
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
proxy-method-routing
branch
from
2bee87b
to
375c69f
Compare
|
💥 Acceptance test Core-API-Tests-ocis-storage-1 failed. Further test are cancelled... |
C0rby
reviewed
Apr 13, 2022
proxy/pkg/proxy/proxy.go
Outdated
| @@ -124,6 +125,7 @@ func (p *MultiHostReverseProxy) directorSelectionDirector(r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| method := "" | |||
There was a problem hiding this comment.
I can't fully wrap my head around this at the moment but shouldn't this be defined inside of the loop or at least be reset to an empty string at the beginning of the loop?
|
Kudos, SonarCloud Quality Gate passed! |
|
merged as part of #3635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a method property to proxy routes that allows routing requests to a different backend.
We need this to route
REPORTrequests to the ocis webdav service to implement search