Share not created with default permissions #1277

dpakach · 2020-06-30T03:42:07Z

While creating the share if we dont specify the permission, it doesn't use one by default.

e.g.

no permission specified

❯ curl -k -u tu1:1234 -XPOST http://localhost:9140/ocs/v1.php/apps/files_sharing/api/v1/shares -d path=file.txt -d shareType=3 -v 
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying 127.0.0.1:9140...
* TCP_NODELAY set
* Connected to localhost (127.0.0.1) port 9140 (#0)
* Server auth using Basic with user 'tu1'
> POST /ocs/v1.php/apps/files_sharing/api/v1/shares HTTP/1.1
> Host: localhost:9140
> Authorization: Basic dHUxOjEyMzQ=
> User-Agent: curl/7.68.0
> Accept: */*
> Content-Length: 25
> Content-Type: application/x-www-form-urlencoded
> 
* upload completely sent off: 25 out of 25 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Vary: Origin
< X-Access-Token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZXZhIiwiZXhwIjoxNTkzNDkyMDgyLCJpYXQiOjE1OTM0ODg0ODIsImlzcyI6Imh0dHBzOi8vbG9jYWxob3N0OjkyMDAiLCJ1c2VyIjp7ImlkIjp7ImlkcCI6Imh0dHBzOi8vbG9jYWxob3N0OjkyMDAiLCJvcGFxdWVfaWQiOiJ0dTEifSwidXNlcm5hbWUiOiJ0dTEiLCJtYWlsIjoidHUxQGV4YW1wbGUub3JnIn19.fqJ5XmRG-t7ea_9v3-0CWKCtzaQQcQkZ1l7h2feGKac
< Date: Tue, 30 Jun 2020 03:41:22 GMT
< Content-Length: 0
< 
* Connection #0 to host localhost left intact

With permission specified

❯ curl -k -u tu1:1234 -XPOST http://localhost:9140/ocs/v1.php/apps/files_sharing/api/v1/shares -d permissions=4 -d path=file.txt -d shareType=3 -v
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying 127.0.0.1:9140...
* TCP_NODELAY set
* Connected to localhost (127.0.0.1) port 9140 (#0)
* Server auth using Basic with user 'tu1'
> POST /ocs/v1.php/apps/files_sharing/api/v1/shares HTTP/1.1
> Host: localhost:9140
> Authorization: Basic dHUxOjEyMzQ=
> User-Agent: curl/7.68.0
> Accept: */*
> Content-Length: 39
> Content-Type: application/x-www-form-urlencoded
> 
* upload completely sent off: 39 out of 39 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Vary: Origin
< X-Access-Token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZXZhIiwiZXhwIjoxNTkzNDkxOTk5LCJpYXQiOjE1OTM0ODgzOTksImlzcyI6Imh0dHBzOi8vbG9jYWxob3N0OjkyMDAiLCJ1c2VyIjp7ImlkIjp7ImlkcCI6Imh0dHBzOi8vbG9jYWxob3N0OjkyMDAiLCJvcGFxdWVfaWQiOiJ0dTEifSwidXNlcm5hbWUiOiJ0dTEiLCJtYWlsIjoidHUxQGV4YW1wbGUub3JnIn19.MlE5MG05XBEBEQga_xvrpK0ukjM6915vB7LYl62gric
< Date: Tue, 30 Jun 2020 03:40:00 GMT
< Content-Length: 1030
< Content-Type: text/xml; charset=utf-8
< 
<?xml version="1.0" encoding="UTF-8"?>
<ocs><meta><status>ok</status><statuscode>100</statuscode><message>OK</message></meta><data><id>BRvCKVOuHfyS</id><share_type>3</share_type><uid_owner>tu1@https://localhost:9200</uid_owner><displayname_owner></displayname_owner><permissions>4</permissions><stime>1593488400</stime><parent></parent><expiration></expiration><token>suECupWuxgDD</token><uid_file_owner>tu1</uid_file_owner><displayname_file_owner></displayname_file_owner><additional_info_owner></additional_info_owner><additional_info_file_owner></additional_info_file_owner><state>0</state><path>/file.txt</path><item_type>file</item_type><mimetype>application/octet-stream</mimetype><storage_id>1284d238-aa92-42ce-bdc4-0b0000009158</storage_id><storage>0</storage><item_source>394600120320</item_source><file_source>394600120320</file_source><file_parent></file_parent><file_target>/file.txt</file_target><share_with_additional_info></share_with_additional_info><mail_send></mail_send><url>/#/s/suECupWuxgDD</url></data>* Connection #0 to host localhost left intact
</ocs>%

The text was updated successfully, but these errors were encountered:

jasson99 · 2021-04-15T11:38:05Z

The behaviour now seems to be a bit different.

No permission specified:

curl -k -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d path=file.txt -d shareType=3 -u tu1:1234 |xmllint --format -

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>ok</status>
    <statuscode>100</statuscode>
    <message>OK</message>
  </meta>
  <data>
    <id>TwxKRUXOLoJinyx</id>
    <share_type>3</share_type>
    <uid_owner>tu1</uid_owner>
    <displayname_owner>tu1</displayname_owner>
    <additional_info_owner>tu1@example.com</additional_info_owner>
    <permissions>1</permissions>
    <stime>1618486387</stime>
    <parent/>
    <expiration/>
    <token>gkenAwNCpxaMJLb</token>
    <uid_file_owner>tu1</uid_file_owner>
    <displayname_file_owner>tu1</displayname_file_owner>
    <additional_info_file_owner>tu1@example.com</additional_info_file_owner>
    <state>0</state>
    <path>/file.txt</path>
    <item_type>file</item_type>
    <mimetype>text/plain</mimetype>
    <storage_id>1284d238-aa92-42ce-bdc4-0b0000009157</storage_id>
    <storage>0</storage>
    <item_source>MTI4NGQyMzgtYWE5Mi00MmNlLWJkYzQtMGIwMDAwMDA5MTU3OjQ2NzhlM2I4LWY3Y2QtNDRjMi1iMzMwLTNhMmFiMjJhNjJmOQ==</item_source>
    <file_source>MTI4NGQyMzgtYWE5Mi00MmNlLWJkYzQtMGIwMDAwMDA5MTU3OjQ2NzhlM2I4LWY3Y2QtNDRjMi1iMzMwLTNhMmFiMjJhNjJmOQ==</file_source>
    <file_parent/>
    <file_target>/file.txt</file_target>
    <share_with_additional_info/>
    <mail_send>0</mail_send>
    <name/>
    <url>https://localhost:9200/#/s/gkenAwNCpxaMJLb</url>
  </data>
</ocs>

Permissions specified:

curl -k -u tu1:1234 -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d permissions=3 -d path=file.txt -d shareType=3 |xmllint --format -

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>error</status>
    <statuscode>400</statuscode>
    <message>Could not read permission from request</message>
  </meta>
</ocs>

curl -k -u tu1:1234 -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d permissions=15 -d path=file.txt -d shareType=3 |xmllint --format -

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>ok</status>
    <statuscode>100</statuscode>
    <message>OK</message>
  </meta>
  <data>
    <id>ntMrseYsxKAyXkh</id>
    <share_type>3</share_type>
    <uid_owner>tu1</uid_owner>
    <displayname_owner>tu1</displayname_owner>
    <additional_info_owner>tu1@example.com</additional_info_owner>
    <permissions>3</permissions>
    <stime>1618989126</stime>
    <parent/>
    <expiration/>
    <token>eSeunsLEcVNiBcW</token>
    <uid_file_owner>tu1</uid_file_owner>
    <displayname_file_owner>tu1</displayname_file_owner>
    <additional_info_file_owner>tu1@example.com</additional_info_file_owner>
    <state>0</state>
    <path>/file.txt</path>
    <item_type>file</item_type>
    <mimetype>text/plain</mimetype>
    <storage_id>1284d238-aa92-42ce-bdc4-0b0000009157</storage_id>
    <storage>0</storage>
    <item_source>MTI4NGQyMzgtYWE5Mi00MmNlLWJkYzQtMGIwMDAwMDA5MTU3OjQ2NzhlM2I4LWY3Y2QtNDRjMi1iMzMwLTNhMmFiMjJhNjJmOQ==</item_source>
    <file_source>MTI4NGQyMzgtYWE5Mi00MmNlLWJkYzQtMGIwMDAwMDA5MTU3OjQ2NzhlM2I4LWY3Y2QtNDRjMi1iMzMwLTNhMmFiMjJhNjJmOQ==</file_source>
    <file_parent/>
    <file_target>/file.txt</file_target>
    <share_with_additional_info/>
    <mail_send>0</mail_send>
    <name/>
    <url>https://localhost:9200/#/s/eSeunsLEcVNiBcW</url>
  </data>
</ocs>

curl -k -u tu1:1234 -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d permissions=4 -d path=file.txt -d shareType=3 |xmllint --format -

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>error</status>
    <statuscode>400</statuscode>
    <message>Cannot set the requested share permissions</message>
  </meta>
</ocs>

jasson99 · 2021-04-21T07:57:16Z

Description:

Different share permissions have varying role in core and ocis

In OC10:

Create a share with permissions 31 or default has role specified as Editor.
curl -k -X POST http://localhost/oc/ocs/v2.php/apps/files_sharing/api/v1/shares\?format\=json -d path="new new" -d shareWith="test123" -d permissions=31 -d shareType="0" -u admin:admin -v;
Create a share with permissions 1 has role specified as Advanced Permissions
curl -k -X POST http://localhost/oc/ocs/v2.php/apps/files_sharing/api/v1/shares\?format\=json -d path="new new" -d shareWith="test123" -d permissions=1 -d shareType="0" -u admin:admin -v;
Create a share with permissions 17 has role specified as Viewer
curl -k -X POST http://localhost/oc/ocs/v2.php/apps/files_sharing/api/v1/shares\?format\=json -d path="new new" -d shareWith="test123" -d permissions=17 -d shareType="0" -u admin:admin -v;

In OCIS:

Create a share with permissions 31 or default has role specified as Advanced Permissions.
curl -k -u admin:admin -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d permissions=31 -d path="new new" -d shareType=0 -d shareWith="user1" |xmllint --format -
Create a share with permissions 1 has role specified as Viewer
curl -k -u admin:admin -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d permissions=1 -d path="new new" -d shareType=0 -d shareWith="user1" |xmllint --format -
Create a share with permissions 17 has role specified as Advanced Permissions
curl -k -u admin:admin -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d permissions=17 -d path="new new" -d shareType=0 -d shareWith="user1" |xmllint --format -

kiranparajuli589 · 2022-06-20T07:16:05Z

The behavior has evolved now behaving as:

Link shares

without permission supplied
- share is created with permission 1
- the UI shows Viewer role assigned
with permissions supplied
- permission 3 provided with payload -> share is created with the same permission -> UI shows the Editor role assigned
- permission 4 or 15 or 17 or 31 provided with payload -> share is not created -> message: unknown share types

User shares

without permission supplied
- share is created with permission 19
- UI shows the Editor role assigned
with permission supplied
- permission 1 provided -> share created with permission 1 -> UI shows the Custom Permissions role assigned
- permission 3 provided -> share created with permission 3 -> UI shows the Custom Permissions role assigned
- permission 4 provided -> share is not created -> message: [400]Cannot set the requested share permissions
- permission 15 provided -> share created with permission 3 -> UI shows the Custom Permissions role assigned
- permission 17 provided -> share created with permission 17 -> UI shows the Viewer role assigned
- permission 19 provided -> share created with permission 19 -> UI shows the Editor role assigned
- permission 31 provided -> share created with permission 19 -> UI shows the Editor role assigned

kiranparajuli589 · 2022-06-21T09:19:57Z

After owncloud/web#7136, a lot of the tagged scenarios have been removed.
QA-Team Todo:

investigate the remaining scenarios in the expected failures list

saw-jan · 2022-06-21T10:11:37Z

After owncloud/web#7136, a lot of the tagged scenarios have been removed. QA-Team Todo:

investigate the remaining scenarios in the expected failures list

Also, it would be nice to see if this issue can be closed

amrita-shrestha · 2022-06-22T11:28:28Z

Creating share without specific permission, create user-share with default permission 31 and public-share with default permission 1.That's a actual behavior

In ocis, the behavior has evolved now behaving as:

Link shares

without permission supplied
- share is created with permission 1 (default permission for public-link share)
- the UI shows Viewer role assigned
with permissions supplied
- permission 2 provided -> htpp status code 400 -> message:Could not read permission from request
- permission 3 provided with payload -> share is created with the same permission -> UI shows [ocis] Shares sidebar does not show created public-link with Permission 3 web#7164
- permission 4 provided -> share created with permission 4 -> UI shows the Uploader role assigned
- permission 15 provided -> share created with permission 15 -> UI shows the Editor role assigned
- permission 17 provided -> htpp status code 400 -> message:Could not read permission from request
- permission 31 provided -> share created with permission 1 -> UI shows the Viewer role assigned

User shares

without permission supplied
- share is created with permission 31 (default permission for user-share)
- UI shows the Editor role assigned
with permission supplied
- permission 1 provided -> share created with permission 1 -> UI shows the Custom Permissions (read)role assigned
- permission 2 provided -> share created with permission 2 -> UI shows the Custom Permissions (Update)role assigned
- permission 3 provided -> share created with permission 3 -> UI shows the Custom Permissions role assigned (read, update)
- permission 4 provided ->share created with permission 4 -> UI shows the Custom Permissions (create)role assigned
- permission 5 provided ->share created with permission 5 -> UI shows the Custom Permissions (read,create)role assigned
- permission 6 provided -> share created with permission 6 -> UI shows the Custom Permissions (Update,create)role assigned
- permission 7 provided -> share created with permission 3 -> UI shows the Custom Permissions role assigned (read, update,create)
- permission 15 provided -> share created with permission 15 -> UI shows the Custom Permissions role assigned (read, update,create, delete )
- permission 17 provided -> share created with permission 17 -> UI shows the Viewer role assigned
- permission 19 provided -> share created with permission 19 -> UI shows the Custom Permissions role assigned(read, update, share)
- permission 31 provided -> share created with permission 31 -> UI shows the Editor role assigned

amrita-shrestha · 2022-06-24T05:45:32Z

investigate the remaining scenarios in the expected failures list

This issue has been solved but there are many scenarios under this issue in the expected failure list. Need a lot of changes on that scenario to pass. Should be discussed first Is it worth investing time in such a task. Until any decision is made transfered into the backlog.

SwikritiT · 2022-07-06T11:12:48Z

This issue no longer exists so closing. There are some tests linked to this issue in expected to fail which will be handled in different PR https://github.com/owncloud/web/blob/67458fceb836429e9f2091b65d25ef42664064db/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md?plain=1#L161

SwikritiT · 2022-07-08T07:56:25Z

follow up PR for expected to fail here owncloud/web#7246

butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021

refs added Type:Bug Storage:EOS labels Jan 18, 2021

refs changed the title ~~[EOS] share not created with default permissions~~ Share not created with default permissions Jan 18, 2021

settings bot removed the Storage:EOS label Jan 29, 2021

exalate-issue-sync bot added the p3-medium label Feb 10, 2021

settings bot removed the p3-medium label Apr 7, 2021

SwikritiT mentioned this issue Mar 15, 2022

[full-ci] Set OCS version to up to date values #2918

Merged

9 tasks

kiranparajuli589 mentioned this issue Jun 20, 2022

[full-ci][tests-only] bump ocis commit id for the tests owncloud/web#7136

Merged

10 tasks

amrita-shrestha self-assigned this Jun 22, 2022

amrita-shrestha closed this as completed Jun 23, 2022

amrita-shrestha reopened this Jun 23, 2022

amrita-shrestha added the QA:team label Jun 29, 2022

butonic mentioned this issue Jun 30, 2022

ocdav: skip space lookup on spaces propfind cs3org/reva#2977

Merged

SwikritiT unassigned amrita-shrestha Jul 6, 2022

SwikritiT closed this as completed Jul 6, 2022

SwikritiT mentioned this issue Jul 8, 2022

[tests-only][full-ci]Skip test on OCIS related to sharing owncloud/web#7246

Merged

10 tasks

SwikritiT removed the QA:team label Jul 8, 2022

amrita-shrestha mentioned this issue Dec 20, 2022

Api tests scenario related to share permission needs changes #5249

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Share not created with default permissions #1277

Share not created with default permissions #1277

dpakach commented Jun 30, 2020

jasson99 commented Apr 15, 2021 •

edited

Loading

jasson99 commented Apr 21, 2021

kiranparajuli589 commented Jun 20, 2022 •

edited

Loading

kiranparajuli589 commented Jun 21, 2022

saw-jan commented Jun 21, 2022

amrita-shrestha commented Jun 22, 2022 •

edited by SwikritiT

Loading

amrita-shrestha commented Jun 24, 2022

SwikritiT commented Jul 6, 2022

SwikritiT commented Jul 8, 2022

Share not created with default permissions #1277

Share not created with default permissions #1277

Comments

dpakach commented Jun 30, 2020

no permission specified

With permission specified

jasson99 commented Apr 15, 2021 • edited Loading

No permission specified:

Permissions specified:

jasson99 commented Apr 21, 2021

Description:

In OC10:

In OCIS:

kiranparajuli589 commented Jun 20, 2022 • edited Loading

The behavior has evolved now behaving as:

kiranparajuli589 commented Jun 21, 2022

saw-jan commented Jun 21, 2022

amrita-shrestha commented Jun 22, 2022 • edited by SwikritiT Loading

In ocis, the behavior has evolved now behaving as:

amrita-shrestha commented Jun 24, 2022

SwikritiT commented Jul 6, 2022

SwikritiT commented Jul 8, 2022

jasson99 commented Apr 15, 2021 •

edited

Loading

kiranparajuli589 commented Jun 20, 2022 •

edited

Loading

amrita-shrestha commented Jun 22, 2022 •

edited by SwikritiT

Loading