-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Skip test on OCIS related to sharing #7246
Conversation
00996f1
to
f71abe1
Compare
Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/26741/62/1 |
c5678a9
to
adb31d5
Compare
adb31d5
to
48f5017
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScharfViktor please take a look if the approach suits you - I see the risk of deleting a lot of test cases that would be valid for oCIS also (but would need adaption since the share jail got merged)
I skipped these because I thought we were not going to update the tests in Nightwatch and these tests need to be updated in order for them to pass on Nightwatch for OCIS. I've mentioned the name of the scenario that is skipped in this PR here #6896 (comment) thinking that since the scenarios are already running in OC10 if we want to transfer it to playwright we can refer to the scenarios there. I can create a separate issue mentioning the complete scenarios skipped in this PR. |
we agreed that we will not waste time for the old UI tests. we will close them but create a task to create new playwrigth tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me then if @ScharfViktor is happy
Description
This PR skips the tests that were linked to the following closed issues:
The skipped tests are the ones that open the
Shares
folder using webUI check for resources or perform other actions. Since the implementation ofShare jail
theShares
folder is not available inpersonal
, so this behavior is outdated forOCIS
but relevant forOC10
. Thus the tests are skipped inOCIS
Related Issue
Motivation and Context
Since we have decided that we won't be putting any effort into updating the Nightwatch tests, the tests that don't adhere with the current behavior of
OCIS
are skipped/removed.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: