Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML properties in webdav response not properly encoded #1296

Closed
dpakach opened this issue May 20, 2020 · 14 comments · Fixed by cs3org/reva#1425
Closed

XML properties in webdav response not properly encoded #1296

dpakach opened this issue May 20, 2020 · 14 comments · Fixed by cs3org/reva#1425
Assignees
Labels
Category:Technical Technical ehancements Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Status:Needs-Info Type:Technical-Debt

Comments

@dpakach
Copy link
Contributor

dpakach commented May 20, 2020

On the xml webdav responses some properties are not properly encoded
for example

filename expected value (Value returned by oc10) Actual value
/folder &2.txt webdav/file%20%262.txt webdav/file%20&2.txt
/C++ folder webdav/C%2b%2b%20folder webdav/C++%20folder/
@PVince81
Copy link
Contributor

is this not the same as owncloud/ocis-reva#122 ?

I see that issue is closed but the tests are still skipped

@PVince81
Copy link
Contributor

I see you mentionned this in owncloud/core#37388

In the future please always create connections between the tickets to make it easier to find the contexts

@PVince81
Copy link
Contributor

never mind, it was referenced indirectly.

usually I think it can be useful to add a sentence in the top post that says where this was discovered and what it related to, to avoid confusion

@PVince81
Copy link
Contributor

PVince81 commented Jun 3, 2020

seems we're using Golang's URL.EscapedPath which apparently decided to not encode the spaces and plus signs

@PVince81
Copy link
Contributor

PVince81 commented Jun 3, 2020

we could use url.QueryEscape() but it needs to done individually on each path section

@PVince81
Copy link
Contributor

PVince81 commented Jun 3, 2020

so I just tried it locally but it encoded with lower case instead of upper case. "%2d" instead of "%2D", so the test also fails 😞

@butonic butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021
@refs refs added Category:Technical Technical ehancements Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Status:Needs-Info labels Jan 18, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jun 6, 2021
@phil-davis
Copy link
Contributor

@dpakach is this still an issue?

@stale stale bot removed the Status:Stale label Jun 7, 2021
@stale
Copy link

stale bot commented Aug 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Aug 6, 2021
@phil-davis
Copy link
Contributor

@dpakach is this still a problem?
I don't see this issue mentioned in expected-failures.

@stale stale bot removed the Status:Stale label Aug 6, 2021
@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@pascalwengerter
Copy link
Contributor

Reopening as technical debt until closed by someone that confirms it's fixed

@phil-davis
Copy link
Contributor

@dpakach I assigned you and put this in the QA Project so that you will noticed it. Please check - if it is fixed, then close. Otherwise mention what the current remaining issue(s) are.

@dpakach
Copy link
Contributor Author

dpakach commented Oct 18, 2021

Just checked on the latest master of ocis. Can confirm that it has been fixed.

  <d:response>
    <d:href>/remote.php/dav/files/admin/C%2b%2b%20folder/</d:href>
  </d:response>
  <d:response>
    <d:href>/remote.php/dav/files/admin/folder%20%262.txt/</d:href>
  </d:response>

@dpakach dpakach closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Technical Technical ehancements Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Status:Needs-Info Type:Technical-Debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants