MOVE a file into same folder with same name returns 404 instead of 403

[saw-jan]

From https://www.rfc-editor.org/rfc/rfc4918#section-9.9.4

403 (Forbidden) - Among many possible reasons for forbidding a MOVE
operation, this status code is recommended for use when the source
and destination resources are the same.

In oCIS

curl -X MOVE -u admin:admin https://localhost:9200/remote.php/dav/files/admin/parent.txt \
-H "Destination: https://localhost:9200/remote.php/dav/files/admin/parent.txt" -v

Response:

< HTTP/1.1 404 Not Found

<?xml version="1.0" encoding="UTF-8"?>
<d:error
	xmlns:d="DAV"
	xmlns:s="http://sabredav.org/ns">
	<s:exception>Sabre\DAV\Exception\NotFound</s:exception>
	<s:message>move: error: not found: 854988f3-a286-4076-a8ca-44d54cf03a08/parent.txt</s:message>
</d:error>

❗ file is then deleted and moved to the trashbin

In oC10

curl -X MOVE -u admin:admin http://localhost/core/remote.php/dav/files/admin/parent.txt \
-H "Destination: http://localhost/core/remote.php/dav/files/admin/parent.txt" -v 

Response

< HTTP/1.1 403 Forbidden

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\Forbidden</s:exception>
  <s:message>Source and destination uri are identical.</s:message>
</d:error>

[ScharfViktor]

I can confirm that this is happening. local server oCIS version 1.11.0

curl -X MOVE -u admin:admin https://localhost:9200/remote.php/webdav/parent.txt \ -H "Destination: https://localhost:9200/remote.php/webdav/parent.txt" -v get 404 and move file to trash

But web blocks this behavior.

[saw-jan]

re-tested with oCIS 1.19.1, still relevant

[amrita-shrestha]

re-tested with ocis 3.1.0-rc.1+712d98e0a2, still relevant

[saw-jan]

This deletes the file and moves it to the trashbin. So I think it should be treated with similar prio as bug #6739

CC @ScharfViktor

[saw-jan]

• API test coverage ([tests-only] Added API tests coverage for MOVE within same folder with same filename #8135)