Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create WebDAV API tests for accessing files by fileID #6737

Closed
2 of 5 tasks
individual-it opened this issue Jul 7, 2023 · 6 comments
Closed
2 of 5 tasks

create WebDAV API tests for accessing files by fileID #6737

individual-it opened this issue Jul 7, 2023 · 6 comments
Assignees
Labels

Comments

@individual-it
Copy link
Member

individual-it commented Jul 7, 2023

It is possible to do WebDAV operations using only the fileID. That file can be located in any subfolder, the folder name does not need to be known:
e.g.:
curl -uadmin:admin -k 'https://localhost:9200/remote.php/dav/spaces/<fileId>' -XPROPFIND

curl -uadmin:admin -k 'https://localhost:9200/remote.php/dav/spaces/33c9baa8-450f-4873-a049-7beb8227face$136ffc9b-d317-4219-a0c3-084d5e070c60!0b8eff1a-8401-4bda-a7e7-8333e44e4ded' -XMOVE -H 'Destination: https://localhost:9200/remote.php/dav/spaces/33c9baa8-450f-4873-a049-7beb8227face%24136ffc9b-d317-4219-a0c3-084d5e070c60/Neuer%20Ordner/Artur.txt'

I don't think we have tests for that, but we should.

try that all inside of subfolders & different spaces
try that all with fileIds of other users
try that all with fileId of shared files / folders
try that all with and without remote.php in the Destination URL, this seems to make a difference see: #6739

@PrajwolAmatya PrajwolAmatya self-assigned this Aug 2, 2023
@amrita-shrestha amrita-shrestha self-assigned this Aug 3, 2023
@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented Aug 3, 2023

using fileid we can't rename,copy,move files in new and old dav-path-version .I think this issue valid for space dav-path-version only

@individual-it
Copy link
Member Author

@amrita-shrestha yes that is true, these tests should only be written for the spaces endpoint

@SagarGi
Copy link
Member

SagarGi commented Sep 18, 2023

Lets first add tests The below tests

PROPFIND by ID contract

Inside Personal Space

Copy

Move

Inside Project Space

Copy

Move

Between Project Space

Copy

Move

Copy Between Spaces (Between Personal and Project Space)

Copy

Move

Inside the Shares Jail (Shares)

NOTE: This is the place where we will be using (virtual shares id or mountpoint id of the shared file or folder) Before implementing it please make sure which id to use

Copy

Move

Copy Between Spaces (Between Personal and Share Space)

Copy

Move

@grgprarup grgprarup assigned SagarGi and nabim777 and unassigned SagarGi Oct 3, 2023
@saw-jan
Copy link
Member

saw-jan commented Dec 11, 2023

Follow up on the issues mentioned in the above description.
CC @SagarGi

@SagarGi
Copy link
Member

SagarGi commented Dec 11, 2023

Follow up on the issues mentioned in the above description. CC @SagarGi

@saw-jan @SwikritiT All the issues mentioned in the Copy and Move/Rename is possible through the file id and is done in #6737 (comment) which seems possible except deleting files/folders with file ID. So may be those issues seems mentioned seems to be different and unrelated to this issue. The Test coverage regarding the webdav operation with file_id seems to be covered. So this issue can be closed.

@SwikritiT
Copy link
Contributor

Follow up on the issues mentioned in the above description. CC @SagarGi

@saw-jan @SwikritiT All the issues mentioned in the Copy and Move/Rename is possible through the file id and is done in #6737 (comment) which seems possible except deleting files/folders with file ID. So may be those issues seems mentioned seems to be different and unrelated to this issue. The Test coverage regarding the webdav operation with file_id seems to be covered. So this issue can be closed.

Closing this issue as per this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants