Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add test for move with fileID in project space #7421

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[tests-only][full-ci]add test for move with fileID in project space #7421

merged 1 commit into from
Oct 9, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Oct 6, 2023 •
edited
Loading

Description

This PR adds the test for moving the files within project space with the url consisting of the file-id not name and for moving with file id only within Project Space

Related Issue

@nabim777 nabim777 self-assigned this Oct 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@nabim777 nabim777 mentioned this pull request Oct 7, 2023
Closed
5 tasks
SagarGi
SagarGi approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 but @nabim777 Please also add for rename ? May be in next PR

@SagarGi SagarGi merged commit 140f756 into master Oct 9, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-on-move-with-fileID-project-spaces branch October 9, 2023 03:30
ownclouders pushed a commit that referenced this pull request Oct 9, 2023
@nabim777
add test for move with fileID in project space (#7421)
daeea2e
nabim777 added a commit that referenced this pull request Oct 10, 2023
@nabim777
add test for move with fileID in project space (#7421)
606dbf3
@nabim777 nabim777 mentioned this pull request Oct 10, 2023
Merged
SagarGi pushed a commit that referenced this pull request Oct 11, 2023
@nabim777
add test for move with fileID in project space (#7421) (#7443)
1700024
ownclouders pushed a commit that referenced this pull request Oct 11, 2023
@nabim777
add test for move with fileID in project space (#7421) (#7443)
8db3386
ownclouders pushed a commit that referenced this pull request Oct 12, 2023
@nabim777
add test for move with fileID in project space (#7421) (#7443)
2417034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi SagarGi approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabim777 @SagarGi @saw-jan