Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Add tests for move rename file between personal and project space with file id #7535

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[tests-only][full-ci] Add tests for move rename file between personal and project space with file id #7535

merged 1 commit into from
Nov 21, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Oct 19, 2023 •
edited by saw-jan
Loading

Description

This PR adds the test for moving and renaming the files betweeen project space and personal space with the url consisting of the file-id not name
In this PR following scenario are added:

  • move a file from project to personal space
  • move a file from personal to project space
  • rename a file and move a file from project space to personal space
  • rename a file and move a file from personal space to project space

Related Issue

@nabim777 nabim777 self-assigned this Oct 19, 2023
@nabim777 nabim777 mentioned this pull request Oct 19, 2023
Closed
5 tasks
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from 2b5bf97 to efd62c3 Compare October 20, 2023 04:09
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch 2 times, most recently from 569bb3e to 94e136b Compare October 20, 2023 08:37
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from 94e136b to 10e4b7a Compare October 26, 2023 04:09
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from 10e4b7a to 369bac2 Compare October 26, 2023 04:12
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch 3 times, most recently from 3262e3a to 4a28f72 Compare November 10, 2023 09:07
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from 4a28f72 to 6ae2402 Compare November 16, 2023 06:01
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch 3 times, most recently from dfb2bd8 to cc94496 Compare November 16, 2023 11:12
saw-jan
saw-jan reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SwikritiT
SwikritiT reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me. But the branch is very behind master https://github.com/owncloud/ocis/tree/add-test-on-move-rename-between-fileID-project-spaces

Please rebase and push

@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from cc94496 to dc74aad Compare November 20, 2023 07:15
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from dc74aad to fb5d4a3 Compare November 20, 2023 10:33
@ScharfViktor ScharfViktor force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from fb5d4a3 to aff9bf3 Compare November 20, 2023 16:47
@ScharfViktor ScharfViktor mentioned this pull request Nov 20, 2023
Closed
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from aff9bf3 to 6e7b91e Compare November 21, 2023 06:46
@nabim777 nabim777 force-pushed the add-test-on-move-rename-between-fileID-project-spaces branch from 6e7b91e to 5187f33 Compare November 21, 2023 06:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit 42690f3 into master Nov 21, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-on-move-rename-between-fileID-project-spaces branch November 21, 2023 11:00
ownclouders pushed a commit that referenced this pull request Nov 21, 2023
@nabim777
add tests for move rename file between personal and project space wit…
1b954d8 
…h file-id (#7535)
@nabim777 nabim777 mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nabim777 @grgprarup @SwikritiT @SagarGi @saw-jan @ScharfViktor