Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test for previewing shared resource using spaces dav version #7234

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[tests-only][full-ci] added test for previewing shared resource using spaces dav version #7234

merged 1 commit into from
Oct 12, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Sep 6, 2023 •
edited
Loading

Description

This PR implements the previewing of shared files using the spaces WebDav. For spaces DAV path, getting preview or uploading content on shared resource requires mount point id. Method to get mount point id getMountPointId is added and used for previewing the shared resources.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya mentioned this pull request Sep 7, 2023
Closed
3 tasks
@PrajwolAmatya PrajwolAmatya self-assigned this Sep 7, 2023
@PrajwolAmatya PrajwolAmatya changed the title [tests-only][full-ci] added test for previewing shared resource using spaces WebDav [tests-only][full-ci] added test for previewing shared resource using spaces dav version Sep 8, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Sep 8, 2023
Merged
10 tasks
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-preview-shared-resource-spaces-webdav branch 7 times, most recently from 4e5eea8 to de5dafd Compare September 25, 2023 08:49
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review September 25, 2023 09:50
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-preview-shared-resource-spaces-webdav branch from de5dafd to e743576 Compare September 26, 2023 06:46
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-preview-shared-resource-spaces-webdav branch from fd3978b to 744c705 Compare October 4, 2023 08:19
@PrajwolAmatya PrajwolAmatya changed the title [tests-only] added test for previewing shared resource using spaces dav version [tests-only][full-ci] added test for previewing shared resource using spaces dav version Oct 6, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-preview-shared-resource-spaces-webdav branch 2 times, most recently from 8e2ca76 to a85edd9 Compare October 10, 2023 05:38
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-preview-shared-resource-spaces-webdav branch from a85edd9 to 84639ab Compare October 10, 2023 10:59
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-preview-shared-resource-spaces-webdav branch 3 times, most recently from 2d4e775 to a213ce4 Compare October 11, 2023 04:21
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-preview-shared-resource-spaces-webdav branch from a213ce4 to f4b08e6 Compare October 11, 2023 08:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amrita-shrestha
Copy link
Contributor

@PrajwolAmatya I couldn't find the preview test for space share. Are there any tests for that maybe we could add some in new PR

@PrajwolAmatya
Copy link
Contributor Author

@PrajwolAmatya I couldn't find the preview test for space share. Are there any tests for that maybe we could add some in new PR

We can add them in another PR.

grgprarup
grgprarup approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, please make a bump PR in Reva-edge if these work for Reva too.

@PrajwolAmatya
Copy link
Contributor Author

👍 LGTM, please make a bump PR in Reva-edge if these work for Reva too.

Checked on reva and CI was green. So merging this PR.

@PrajwolAmatya PrajwolAmatya merged commit 71f0a25 into stable-4.0 Oct 12, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test-for-preview-shared-resource-spaces-webdav branch October 12, 2023 05:54
ownclouders pushed a commit that referenced this pull request Oct 12, 2023
@PrajwolAmatya
added test coverage for previewing shared resources using spaces dav …
25b0345 
…path (#7234)
@PrajwolAmatya PrajwolAmatya mentioned this pull request Oct 12, 2023
Merged
9 tasks
ownclouders pushed a commit that referenced this pull request Oct 13, 2023
@PrajwolAmatya
added test coverage for previewing shared resources using spaces dav …
384cb65 
…path (#7234)
@PrajwolAmatya PrajwolAmatya mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@KarunAtreya KarunAtreya Awaiting requested review from KarunAtreya

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PrajwolAmatya @amrita-shrestha @grgprarup @KarunAtreya @SagarGi @saw-jan