[tests-only][full-ci] Add test coverage for file preview using space dav version #7218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
amrita-shrestha
force-pushed
the
add-preview-tests-on-spaces-dav
branch
from
e1907f8
to
231b17e
Compare
amrita-shrestha
requested review from
saw-jan,
SwikritiT,
grgprarup,
SagarGi and
PrajwolAmatya
saw-jan
reviewed
Sep 6, 2023
SwikritiT
reviewed
Sep 6, 2023
SagarGi
reviewed
Sep 7, 2023
PrajwolAmatya
force-pushed
the
add-preview-tests-on-spaces-dav
branch
from
231b17e
to
16ab255
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
approved these changes
Sep 8, 2023
delete-merged-branch
bot
deleted the
add-preview-tests-on-spaces-dav
branch
ownclouders
pushed a commit
that referenced
this pull request
Sep 11, 2023
…dav version (#7218) * Add tests for preview using space dav~ * use makeDavRequest to get preview of resource --------- Co-authored-by: prajwol <prajwolamatya11@gmail.com>
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously there was test coverage for previewing resources using new wed-dav only. This PR has added tests coverage of preview using old and spaces wed-dav version in personal spaces.
This PR does not cover the test for previewing the resources using spaces dav version for shared resources. Previewing the shared resource requires the
virtual shares idormount point idand the method to get the id exits inSpacesContextfile and to get them inWebDabHelpermight require some refactoring. So, the previewing of the shared resource is implement in this follow up PR #7234Related Issue
How Has This Been Tested?
Types of changes
Checklist: