Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Extend API test coverage for MOVE between spaces #8113

Merged
merged 2 commits into from
Jan 3, 2024
Merged

[tests-only] Extend API test coverage for MOVE between spaces #8113

merged 2 commits into from
Jan 3, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 3, 2024 •
edited
Loading

Description

Extends MOVE API test coverage:

Using file path

from from (role) to to (role) result API coverage
project manager/editor project(same) 201 👍 ✔️
project viewer project(same) 403 👍 ✔️
project manager/editor project manager/editor 502 ❓ ✔️
project manager/editor project viewer 403 👍 ✔️
project viewer project manager/editor/viewer 403 👍 ✔️
project manager/editor personal   502 ❓ ✔️
project viewer personal   403 👍 ✔️
project manager/editor/viewer share jail all/editor/viewer 403 👍 ✔️
personal   personal(same) 201 👍 ✔️
personal   personal(subfolder) 201 👍 ✔️
personal   project manager/editor 502 ❓ ✔️
personal   project viewer 403 👍 ✔️
personal   share jail all/editor/viewer 403 👍 ✔️
share jail all/editor/viewer personal   403 👍 ✔️
share jail all/editor/viewer project manager/editor/viewer 403 👍 ✔️
share jail all/editor/viewer share jail all/editor/viewer 403 👍 ✔️
share jail all/editor share jail(same) 201 👍 ✔️
share jail viewer share jail(same) 403 👍 ✔️

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Jan 3, 2024
@saw-jan saw-jan self-assigned this Jan 3, 2024
saw-jan
saw-jan commented Jan 3, 2024
View reviewed changes
tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature
@@ -10,21 +10,6 @@ Feature: sharing
| Alice |
| Brian |

@smokeTest
Scenario Outline: moving a file into a share as recipient
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate test scenarios

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ScharfViktor ScharfViktor merged commit 0f9f996 into master Jan 3, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/extend-MOVE-test-coverage branch January 3, 2024 11:10
ownclouders pushed a commit that referenced this pull request Jan 3, 2024
@saw-jan
[tests-only] Extend API test coverage for MOVE between spaces (#8113)
99d1a19 
* extend API test coverage for MOVE between spaces

* update line numbers
saw-jan added a commit that referenced this pull request Jan 3, 2024
@saw-jan
[tests-only] Extend API test coverage for MOVE between spaces (#8113)
bb64957 
* extend API test coverage for MOVE between spaces

* update line numbers
@saw-jan saw-jan mentioned this pull request Jan 3, 2024
Closed
ownclouders pushed a commit that referenced this pull request Jan 4, 2024
@saw-jan
[tests-only] Extend API test coverage for MOVE between spaces (#8113)
3aa4180 
* extend API test coverage for MOVE between spaces

* update line numbers
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@saw-jan @2403905
[tests-only] Extend API test coverage for MOVE between spaces (ownclo…
3ea9582 
…ud#8113)

* extend API test coverage for MOVE between spaces

* update line numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OCIS-storage] not possible to move file into a received folder
2 participants
@saw-jan @ScharfViktor