[OCIS-storage] not possible to move file into a received folder

[individual-it]

trying to move a file into a received folder

receives a HTTP 500 Error

OCIS logs:

2020-10-28T15:04:13+05:45 ERR datasvc: file not found error="error: not found: 1a24d22e-d3cd-420d-a944-6a898641a2db/4c510ada-c86b-4815-8820-42cdf82c3d51" pkg=rhttp service=storage traceid=da8dda58ebf4976b44067b195eb7045e
2020-10-28T15:04:13+05:45 WRN http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=0 start="28/Oct/2020:15:04:13 +0545" status=404 time_ns=123136 traceid=da8dda58ebf4976b44067b195eb7045e uri=/data/index.cs3/unique.github.com.owncloud.ocis.accounts.pkg.proto.v0.Account.OnPremisesSamAccountName/4c510ada-c86b-4815-8820-42cdf82c3d51 url=/data/index.cs3/unique.github.com.owncloud.ocis.accounts.pkg.proto.v0.Account.OnPremisesSamAccountName/4c510ada-c86b-4815-8820-42cdf82c3d51
2020-10-28T15:04:13+05:45 INF access token is already provided pkg=rhttp service=storage traceid=2c582625ff757bbde6251963b6026b4d
2020-10-28T15:04:13+05:45 INF http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=584 start="28/Oct/2020:15:04:13 +0545" status=200 time_ns=307592 traceid=2c582625ff757bbde6251963b6026b4d uri=/data/accounts/4c510ada-c86b-4815-8820-42cdf82c3d51 url=/data/accounts/4c510ada-c86b-4815-8820-42cdf82c3d51
2020-10-28T15:04:13+05:45 INF access token is already provided pkg=rhttp service=storage traceid=1b108f16403546b34c87dd7e5764dab4
2020-10-28T15:04:13+05:45 INF http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=326 start="28/Oct/2020:15:04:13 +0545" status=200 time_ns=334725 traceid=1b108f16403546b34c87dd7e5764dab4 uri=/data/groups/509a9dcd-bb37-4f4f-a01a-19dca27d9cfa url=/data/groups/509a9dcd-bb37-4f4f-a01a-19dca27d9cfa
2020-10-28T15:04:13+05:45 INF access token is already provided pkg=rhttp service=storage traceid=e5d3d805fccc01fc854975633da0124b
2020-10-28T15:04:13+05:45 INF http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=198 start="28/Oct/2020:15:04:13 +0545" status=200 time_ns=351953 traceid=e5d3d805fccc01fc854975633da0124b uri=/data/groups/6040aa17-9c64-4fef-9bd0-77234d71bad0 url=/data/groups/6040aa17-9c64-4fef-9bd0-77234d71bad0
2020-10-28T15:04:13+05:45 INF access token is already provided pkg=rhttp service=storage traceid=86d7af422bd8bbfaa3e250796dc4e003
2020-10-28T15:04:13+05:45 INF http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=196 start="28/Oct/2020:15:04:13 +0545" status=200 time_ns=139594 traceid=86d7af422bd8bbfaa3e250796dc4e003 uri=/data/groups/dd58e5ec-842e-498b-8800-61f2ec6f911f url=/data/groups/dd58e5ec-842e-498b-8800-61f2ec6f911f
2020-10-28T15:04:13+05:45 INF access token is already provided pkg=rhttp service=storage traceid=7e188418a487671ba2125e38775cdfe7
2020-10-28T15:04:13+05:45 INF http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=290 start="28/Oct/2020:15:04:13 +0545" status=200 time_ns=85058 traceid=7e188418a487671ba2125e38775cdfe7 uri=/data/groups/262982c1-2362-4afa-bfdf-8cbfef64a06e url=/data/groups/262982c1-2362-4afa-bfdf-8cbfef64a06e
2020-10-28T15:04:13+05:45 INF access token is already provided pkg=rhttp service=storage traceid=8036d39c1825d8b66af7851d10d73a5d
2020-10-28T15:04:13+05:45 INF http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=36 start="28/Oct/2020:15:04:13 +0545" status=200 time_ns=119581 traceid=8036d39c1825d8b66af7851d10d73a5d uri=/data/index.cs3/unique.github.com.owncloud.ocis.accounts.pkg.proto.v0.Account.OnPremisesSamAccountName/reva url=/data/index.cs3/unique.github.com.owncloud.ocis.accounts.pkg.proto.v0.Account.OnPremisesSamAccountName/reva
2020-10-28T15:04:13+05:45 INF access token is already provided pkg=rhttp service=storage traceid=5162286256c5178200dbfcd3ab1e23eb
2020-10-28T15:04:13+05:45 INF http end="28/Oct/2020:15:04:13 +0545" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=storage size=453 start="28/Oct/2020:15:04:13 +0545" status=200 time_ns=100659 traceid=5162286256c5178200dbfcd3ab1e23eb uri=/data/accounts/bc596f3c-c955-4328-80a0-60d018b4ad57 url=/data/accounts/bc596f3c-c955-4328-80a0-60d018b4ad57
2020-10-28T15:04:13+05:45 INF unary code=OK end="28/Oct/2020:15:04:13 +0545" from=tcp://127.0.0.1:40820 pkg=rgrpc service=storage start="28/Oct/2020:15:04:13 +0545" time_ns=101455866 traceid=298fb1093ae367efa1ab495c5ccf2cde uri=/cs3.identity.user.v1beta1.UserAPI/GetUser user-agent=grpc-go/1.26.0
2020-10-28T15:04:13+05:45 INF unary code=OK end="28/Oct/2020:15:04:13 +0545" from=tcp://127.0.0.1:46402 pkg=rgrpc service=storage start="28/Oct/2020:15:04:13 +0545" time_ns=102319531 traceid=298fb1093ae367efa1ab495c5ccf2cde uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0
2020-10-28T15:04:13+05:45 INF unary code=OK end="28/Oct/2020:15:04:13 +0545" from=tcp://127.0.0.1:54396 pkg=rgrpc service=storage start="28/Oct/2020:15:04:13 +0545" time_ns=104532418 traceid=298fb1093ae367efa1ab495c5ccf2cde uri=/cs3.gateway.v1beta1.GatewayAPI/Stat user-agent=grpc-go/1.26.0
2020-10-28T15:04:13+05:45 ERR home/artur/go/pkg/mod/github.com/cs3org/reva@v1.3.1-0.20201023144216-cdb3d6688da5/internal/grpc/services/gateway/storageprovider.go:1096 >  error="gateway: move called on unknown path: /home/a1.txt" pkg=rgrpc service=storage traceid=298fb1093ae367efa1ab495c5ccf2cde

[refs]

still happens in the current master

[ScharfViktor]

re-tested. you can create a file in the folder "Shares/New folder", but you can't to move file in the folder "Shares/New folder".

[kiranparajuli589]

We're a bit confused about the feature of moving in resources to the Shares space or directory:

• old | new: to Shares dir. from other directories outside
• spaces: to Shares Jail spaces from the Personal space (or other spaces)

Find out this comment from @micbar #4179 (comment) suggests the feature is expected and 502 assertion is a happy pass

according to @butonic 502 is according to spec.

In my ideal world, the clients would not offer a cross storage space move and inform the user that they can do a COPY & DELETE instead. 😄

But this comment from @butonic cs3org/reva#3035 (comment) suggests the feature can reappear in the future.

@labkode the move is only forbidden for decomposedfs. It is technically possible, but requires moving all children, from one space to another, which is why I decided to forbid it for now. Other drivers are not affected.

So how should we write tests for this? Should we check for 502 and do happy pass scenarios or should we check for 201 and let the scenarios fail managed from the expected to failures list?

cc @individual-it @phil-davis

[individual-it]

I'm suggesting to test for 502, in case the behavior will change the test will have to be adjusted

[saw-jan]

Current behavior is 403
Fixed in cs3org/reva#4443

UPDATE: server will return 502 (ref: #8063 (comment))

There are other test scenarios linked to it that still fail. We need to have a look on those test scenarios