Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Added implementation and Scenarios for MOVE request operation #4179

Merged
merged 2 commits into from
Jul 26, 2022
Merged

[tests-only][full-ci]Added implementation and Scenarios for MOVE request operation #4179

merged 2 commits into from
Jul 26, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jul 12, 2022

This PR adds various tests scenarios for MOVE within and with different spaces
This PR Depends on #4126

Part of : #4087

@SagarGi SagarGi mentioned this pull request Jul 12, 2022
Closed
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 3d42947 to dd09547 Compare July 12, 2022 11:16
@ownclouders
Copy link
Contributor

ownclouders commented Jul 12, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from dd09547 to 9e5fcf0 Compare July 13, 2022 04:20
@SagarGi SagarGi self-assigned this Jul 13, 2022
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 9e5fcf0 to 14acf48 Compare July 13, 2022 09:30
@SagarGi
Copy link
Member Author

SagarGi commented Jul 13, 2022

This PR is failing because of this issue #4188

@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 14acf48 to ce6055b Compare July 14, 2022 05:06
@SagarGi SagarGi marked this pull request as ready for review July 14, 2022 05:08
@SagarGi SagarGi changed the title [tests-only]Added implementation and Scenarios for MOVE request operation [tests-only][full-ci]Added implementation and Scenarios for MOVE request operation Jul 15, 2022
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from ce6055b to a0bdbdb Compare July 15, 2022 04:40
@SagarGi SagarGi requested review from kiranparajuli589 and micbar and removed request for micbar July 15, 2022 04:41
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch 2 times, most recently from 459d65e to 0640b29 Compare July 18, 2022 08:57
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 0640b29 to cc8936f Compare July 18, 2022 10:11
@SagarGi SagarGi requested a review from saw-jan July 19, 2022 08:45
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch 3 times, most recently from eb6da3e to 3a1ce2d Compare July 20, 2022 06:59
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 3a1ce2d to 3a2d4c2 Compare July 21, 2022 04:27
@SagarGi SagarGi requested review from micbar and removed request for micbar July 21, 2022 05:00
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 3a2d4c2 to 40a1c3c Compare July 22, 2022 04:29
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 40a1c3c to 1a51433 Compare July 22, 2022 08:38
@SagarGi SagarGi requested a review from SwikritiT July 22, 2022 08:38
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch 2 times, most recently from bf36251 to 740bff8 Compare July 25, 2022 06:23
@SagarGi SagarGi mentioned this pull request Jul 25, 2022
Closed
@SagarGi SagarGi force-pushed the addSpacesTestFormoverequest branch from 740bff8 to 23fa99c Compare July 25, 2022 06:54
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

phil-davis
phil-davis approved these changes Jul 26, 2022
View reviewed changes
tests/acceptance/features/apiSpaces/moveSpaces.feature
| Alice |
| Brian |

Scenario Outline: Moving a file within same space project with role manager and editor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario Outline: Moving a file within same space project with role manager and editor
Scenario Outline: Moving a file within same project space with role manager and editor

"space project" is in a lot of feature files already - I will make a separate PR to discuss fixing that word order.

tests/acceptance/features/apiSpaces/moveSpaces.feature
And user "Brian" has shared a space "Project" to user "Alice" with role "<role>"
And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "<permissions>"
And user "Alice" has accepted share "/testshare" offered by user "Brian"
When user "Alice" moves file "project.txt" from space "Project" to "/testshare/project.txt" inside space "Shares Jail" using the WebDAV API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Shares Jail" never gets mentioned before here in the scenario. It is a bit surprising - there is a special space name "Shares Jail" that already/always exists. This is already in many other scenarios, so it is not a new thing.

We should write something somewhere about this "behavior". I will make a separate issue or PR - listSpaces.feature looks like the place to make a note about this "magic".

@phil-davis phil-davis merged commit 1d94502 into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the addSpacesTestFormoverequest branch July 26, 2022 05:26
ownclouders pushed a commit that referenced this pull request Jul 26, 2022
@phil-davis
commit 1d94502
1d2fc48 
Merge: 1cdea65 23fa99c
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Jul 26 11:11:47 2022 +0545

    Merge pull request #4179 from owncloud/addSpacesTestFormoverequest

    [tests-only][full-ci]Added implementation and Scenarios for `MOVE` request operation
ScharfViktor
ScharfViktor reviewed Jul 26, 2022
View reviewed changes
tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md
- [apiSpaces/moveSpaces.feature:184](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/moveSpaces.feature#L184)
- [apiSpaces/moveSpaces.feature:185](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/moveSpaces.feature#L185)
- [apiSpaces/moveSpaces.feature:186](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/moveSpaces.feature#L186)
- [apiSpaces/moveSpaces.feature:189](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/moveSpaces.feature#L189)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review. tests failed not because I can't copy or move. I'd sudgest to use:

And for user "Alice" folder "testshare" of the space "Shares Jail" should contain these files:
    | personal.txt |

instead of:

And for user "Alice" the space "Shares Jail" should not contain these entries:
      | /testshare/personal.txt |

And create separate tests to checking PROPFIND with Depth infinity.
we can have a lot of working tests instead of waiting for a third-party issue to be fixed

@phil-davis @individual-it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor yes that can be done. I can create separate issue to fix it. shall I?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to be great. You can create a new PR to improve this and that: #4087 (comment)

@kiranparajuli589 kiranparajuli589 mentioned this pull request Aug 24, 2022
Closed
@amrita-shrestha amrita-shrestha mentioned this pull request Aug 24, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@saw-jan saw-jan Awaiting requested review from saw-jan

@micbar micbar Awaiting requested review from micbar

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SagarGi @ownclouders @phil-davis @micbar @kiranparajuli589 @SwikritiT @saw-jan @ScharfViktor