Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] restore scenarios removed from core#40302 #4413

Merged
merged 1 commit into from
Aug 29, 2022
Merged

[tests-only] restore scenarios removed from core#40302 #4413

merged 1 commit into from
Aug 29, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Aug 18, 2022 •
edited
Loading

Signed-off-by: Kiran Parajuli kiranparajuli589@gmail.com

Description

Restore the scenarios removed by core PR owncloud/core#40302.

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch 2 times, most recently from cf0bd34 to 35e8ac8 Compare August 19, 2022 11:34
@kiranparajuli589 kiranparajuli589 mentioned this pull request Aug 22, 2022
Closed
2 tasks
@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch from 35e8ac8 to 1e93790 Compare August 22, 2022 06:10
@kiranparajuli589 kiranparajuli589 self-assigned this Aug 22, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Aug 22, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled...

kiranparajuli589
kiranparajuli589 commented Aug 22, 2022
View reviewed changes
.drone.env Outdated Show resolved Hide resolved
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review August 22, 2022 06:29
SagarGi
SagarGi reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature file contents tests realted to move. We have a moveSpaces.feature already on the suite. may be all these tests can be added to it? or the feature context is different for this?

tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch from 6f4c819 to f1615b9 Compare August 22, 2022 11:14
@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch from f1615b9 to be74e7a Compare August 23, 2022 07:32
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch from be74e7a to 26a61e6 Compare August 23, 2022 10:46
@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch 2 times, most recently from 01a909d to d5fb570 Compare August 23, 2022 11:08
@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch from d5fb570 to f6a15cd Compare August 25, 2022 10:30
SwikritiT
SwikritiT reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing for apiSpaces/changingFilesShare.feature:13

@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch from b8c7606 to de4e15d Compare August 25, 2022 11:15
SagarGi
SagarGi reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍 (except upper review)

@kiranparajuli589
[tests-only] restore the removed scenarios for the core repository
5eee569 
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@kiranparajuli589 kiranparajuli589 force-pushed the ocis-2141/add-removed-space-examples branch from a76a337 to 5eee569 Compare August 29, 2022 04:24
@individual-it individual-it merged commit cdb24a1 into master Aug 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the ocis-2141/add-removed-space-examples branch August 29, 2022 06:36
ownclouders pushed a commit that referenced this pull request Aug 29, 2022
@individual-it
commit cdb24a1
4f0736c 
Merge: b79de5f 5eee569
Author: Artur Neumann <artur@jankaritech.com>
Date:   Mon Aug 29 12:21:01 2022 +0545

    Merge pull request #4413 from owncloud/ocis-2141/add-removed-space-examples

    [tests-only] restore scenarios removed from core#40302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@individual-it individual-it individual-it approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kiranparajuli589 @ownclouders @individual-it @SwikritiT @SagarGi @amrita-shrestha