Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] remove 'Shares' folder including tests examples for Spaces DAV from apiShareOperationsToShares1 #40302

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Description

Removed tests examples involving interactions within Shares folder and spaces WebDAV from suite apiShareOperationsToShares1

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Signed-off-by: Kiran Parajuli kiranparajuli589@gmail.com

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@@ -9,7 +9,7 @@ Feature: sharing
| Alice |
| Brian |

@smokeTest
@smokeTest @notToImplementOnOCIS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiranparajuli589 please remind me - why will this not work on oCIS for Brian to move a file of his into the shared folder received from Alice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phil-davis there's issue regarding it owncloud/ocis#764. And also for spaces owncloud/ocis#4087 (comment) we cannot move resource between spaces. And the response status is 502 for all webdav as per this comment owncloud/ocis#4087 (comment). Maybe it will not be implemented i guess or ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a scenario describing this feature in oCIS. https://github.com/owncloud/ocis/blob/d1f0dbc4c928539fe0a97af8aeb224f5fafb8d22/tests/acceptance/features/apiSpaces/moveSpaces.feature#L113

I think this was a feature so mentioned that @notToImplementOnOCIS tag here. We only can create|upload file inside the Shares Jail but cannot move into|out from it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the last discussion, we let this type of moving-in to sharing folder to run and add to the expected failures.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have closed the issue related to moving files out of Shares owncloud/ocis#2141
According to this issue, actual behavior is we can't move resources out of Shares.
In case of moving resources inside Share, this issue is opened
owncloud/ocis#764

@phil-davis phil-davis self-requested a review August 18, 2022 12:17
…es DAV

Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phil-davis phil-davis merged commit 809f725 into master Aug 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the ocis-2141/remove-space-examples branch August 22, 2022 10:23
kiranparajuli589 added a commit to owncloud/ocis that referenced this pull request Aug 23, 2022
…loud/core#40302

Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants