Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Added test for the copy with file-id in web-dav-url #7308

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Sep 19, 2023

Description

This PR adds test coverage for copying the files within personal space with the url consisting of the file-id not name.
This PR adds copying with file id only within Personal Space

Related issue:

#6737

@SagarGi SagarGi self-assigned this Sep 19, 2023
@SagarGi SagarGi force-pushed the copy_test_with_file_id branch 2 times, most recently from a10c402 to 2074101 Compare September 21, 2023 04:00
@SagarGi SagarGi force-pushed the copy_test_with_file_id branch 2 times, most recently from f3e5bce to 3f702e4 Compare September 21, 2023 04:28
@SagarGi SagarGi marked this pull request as ready for review September 21, 2023 04:55
@SwikritiT
Copy link
Contributor

@SagarGi this branch is a 18 commits behind master https://github.com/owncloud/ocis/tree/copy_test_with_file_id can you please rebase and push

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good to me 👍 ✨

tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✨

@saw-jan saw-jan merged commit ddaa825 into master Sep 26, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the copy_test_with_file_id branch September 26, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants