Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add tests for move file within shares using file-id #7606

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Oct 27, 2023

Description

This PR adds the test for moving the files of shares space with the url consisting of the file-id not name
In this PR following scenario are added:

  • move a file from sub-folder to root inside Shares space

Related Issue

@nabim777 nabim777 force-pushed the add-step-move-for-shares-with-file-id branch from 3de9cf6 to 9b23e44 Compare October 30, 2023 04:51
@nabim777
Copy link
Member Author

nabim777 commented Oct 30, 2023

This PR is block due to this issue #7617
Also discuss in #4087 (comment)

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase the PR

@SwikritiT
Copy link
Contributor

@nabim777 this PR is a lot behind master https://github.com/owncloud/ocis/tree/add-step-move-for-shares-with-file-id please rebase and push

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me

@nabim777 nabim777 force-pushed the add-step-move-for-shares-with-file-id branch from 9b23e44 to c52f2fc Compare November 21, 2023 04:29
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup merged commit 42cdd2c into master Nov 21, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-step-move-for-shares-with-file-id branch November 21, 2023 08:24
ownclouders pushed a commit that referenced this pull request Nov 21, 2023
…file-id

[tests-only][full-ci] Add tests for move file within shares using file-id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants