[test-only][full-ci] added tests for reading content of a file by fileId using WebDav API #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
amrita-shrestha
requested changes
Aug 3, 2023
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
e5bcc53
to
ed03c7f
Compare
PrajwolAmatya
changed the title
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
ed03c7f
to
809ff98
Compare
PrajwolAmatya
requested review from
grgprarup,
SwikritiT,
SagarGi,
saw-jan and
amrita-shrestha
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
809ff98
to
f78b85e
Compare
5 tasks
saw-jan
requested changes
Aug 4, 2023
saw-jan
reviewed
Aug 4, 2023
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
f78b85e
to
e48828b
Compare
SwikritiT
suggested changes
Aug 7, 2023
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
e48828b
to
49f37e5
Compare
saw-jan
reviewed
Aug 7, 2023
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
49f37e5
to
d6e897b
Compare
saw-jan
reviewed
Aug 7, 2023
|
|
||
| Scenario Outline: get content of a file | ||
| Given user "Alice" has uploaded file with content "some data" to "/textfile.txt" | ||
| When user "Alice" gets the content of file "/textfile.txt" with path "<dav-path>" using WebDav API |
There was a problem hiding this comment.
any good suggestions here?
Suggested change
| When user "Alice" gets the content of file "/textfile.txt" with path "<dav-path>" using WebDav API | |
| When user "Alice" gets the content of file "/textfile.txt" from fileId and path "<dav-path>" using WebDav API |
There was a problem hiding this comment.
Suggested change
| When user "Alice" gets the content of file "/textfile.txt" with path "<dav-path>" using WebDav API | |
| When user "Alice" sends HTTP "GET" request to file "/textfile.txt" with path "<dav-path>" | |
There was a problem hiding this comment.
I think instead of adding this new step we can use the existing step When user "Alice" sends HTTP method "GET" to URL "<dav-path>".
@saw-jan @SwikritiT @amrita-shrestha
There was a problem hiding this comment.
Any good suggestions here?
re-using the already present step is great but that doesn't really answer this IMO and I'm just thinking out loud here, I don't have any suggestions, maybe the feature file's name should be explanation enough that the request is done through the fileId ?
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
d132e35
to
0e118f6
Compare
saw-jan
reviewed
Aug 7, 2023
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
0e118f6
to
45042be
Compare
SwikritiT
reviewed
Aug 15, 2023
tests/acceptance/features/apiWebDavOperations/getFileByFileId.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
45042be
to
8c5de07
Compare
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
8c5de07
to
9fad8cf
Compare
PrajwolAmatya
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
9fad8cf
to
affbd47
Compare
PrajwolAmatya
removed request for
phil-davis,
individual-it,
micbar and
wkloucek
saw-jan
reviewed
Aug 15, 2023
tests/acceptance/features/apiSpacesDavOperation/getFileByFileId.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
create-webdav-api-test-for-accessing-files-by-fileid
branch
from
affbd47
to
f1200f7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
approved these changes
Aug 17, 2023
SwikritiT
approved these changes
Aug 18, 2023
phil-davis
approved these changes
Aug 18, 2023
delete-merged-branch
bot
deleted the
create-webdav-api-test-for-accessing-files-by-fileid
branch
ownclouders
pushed a commit
that referenced
this pull request
Aug 18, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the test scenarios for reading the content of a file inside personal space, project space, inside sub-folder, and shared files/folders.
The added test is done with and without
remote.php, in the destination URL./remote.php/dav/spaces/<fileId>/dav/spaces/<fileId>Backport to stable-3.0: [tests-only] [full-ci] Backport access file using file id #7064
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: