Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph/users: enable/disable users #3064

Closed
rhafer opened this issue Jan 31, 2022 · 5 comments
Closed

graph/users: enable/disable users #3064

rhafer opened this issue Jan 31, 2022 · 5 comments

Comments

@rhafer
Copy link
Contributor

rhafer commented Jan 31, 2022

Describe the problem

Our current implementation of the graph API does not allow to query the enabled/disabled state of users. Neither does it support setting it.

For the case where our libregraph implemenation is backed by our own User/Groupmanagement libregraph/idm (or another LDAP Server under our control) we can "invent" our own scheme of enabling/disabling users.

For cases where our libregraph is backed by an extermal service i.e. a read-only Active Directory we need some more flexibility to support whatever the external service provides. For AD e.g. that would need we need to supported the userAccountControl Bitmask attrribute.

Product considerations

  • The ways to disable users vary from Directory to Directory
  • The product needs to react to users which are disappearing from LDAP
  • Currently nothing happens
  • When the user is the last "manager" of a space, the space will be abandoned
  • Timeline: Before GA / After GA

Ways to handle it

  • Disable the users home space
  • Create a multi factor workflow to "unblock" an abandoned space.
  • Support the Microsoft AD way
@micbar
Copy link
Contributor

micbar commented Mar 7, 2022

@pmaier1 I could imagine that we "disable" the users home space when he disappears in LDAP.

We still have one challenge: If the user has been the only "manager" of a project space, it will result in a "stuck" situation.

We will certainly need a solution how to unblock a space with a kind of "multi-factor" process. @hodyroff like we discussed that already.

@micbar micbar added Interaction:Needs-Concept p3-medium Type:Epic Epic is the parent of user stories and removed Type:Bug labels Mar 7, 2022
@micbar
Copy link
Contributor

micbar commented Mar 7, 2022

I would like to discuss that in Product Board.

@pmaier1
Copy link
Contributor

pmaier1 commented Mar 8, 2022

PB

  • Define an LDAP scheme for disabled users ("oC expects this behavior for disabled users")
  • Later: Implement mappings for different LDAP implementations for disabled users
  • Behavior of user disable should be analogous to oC 10 (Use case: "temporary suspended")
  • Next: PB2 to define flow for short-term solution when a user is not in LDAP anymore

When the user is the last "manager" of a space, the space will be abandoned

This needs a general solution as there are other ways to produce this scenario (e.g., simply deleting the last "manager" user).

@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@rhafer
Copy link
Contributor Author

rhafer commented Apr 5, 2023

Basic support for enable/disable users has been added here: #5588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants