Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed issue is still on expected to failure file #816

Closed
5 tasks done
SagarGi opened this issue Jul 3, 2023 · 1 comment
Closed
5 tasks done

Closed issue is still on expected to failure file #816

SagarGi opened this issue Jul 3, 2023 · 1 comment
Assignees
Labels

Comments

@SagarGi
Copy link
Member

SagarGi commented Jul 3, 2023

Description

The below issues are closed in ocis but still in the expected to failure file. It might be good to test those scenarios and check if they are fixed, and also create new issue of those failing scenarios if there are any.

Lists:

Fails on this scenarios:

@issue-5049 @issue-1347 @issue-1292
 Scenario: send MKCOL requests to another user's webDav endpoints as normal user                # /drone/src/tests/acceptance/features/coreApiAuthWebDav/webDavMKCOLAuth.feature:43
   Given user "Brian" has been created with default attributes and without skeleton files       # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
   When user "Brian" requests these endpoints with "MKCOL" including body "" about user "Alice" # OCSContext::userSendsRequestToTheseEndpointsWithBody()
     | endpoint                                           |
     | /remote.php/dav/files/%username%/textfile0.txt     |
     | /remote.php/dav/files/%username%/PARENT            |
     | /remote.php/dav/files/%username%/does-not-exist    |
     | /remote.php/dav/files/%username%/PARENT/parent.txt |
   Then the HTTP status code of responses on all endpoints should be "404"                      # FeatureContext::theHTTPStatusCodeOfResponsesOnAllEndpointsShouldBe()
     Responses did not return expected http status code
     Failed asserting that 409 is identical to 404.

 @issue-5049 @issue-1347 @issue-1292
 Scenario: send MKCOL requests to non-existent user's webDav endpoints as normal user                       # /drone/src/tests/acceptance/features/coreApiAuthWebDav/webDavMKCOLAuth.feature:54
   Given user "Brian" has been created with default attributes and without skeleton files                   # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
   When user "Brian" requests these endpoints with "MKCOL" including body "" about user "non-existent-user" # OCSContext::userSendsRequestToTheseEndpointsWithBody()
     | endpoint                                                  |
     | /remote.php/dav/files/non-existent-user/textfile0.txt     |
     | /remote.php/dav/files/non-existent-user/PARENT            |
     | /remote.php/dav/files/non-existent-user/does-not-exist    |
     | /remote.php/dav/files/non-existent-user/PARENT/parent.txt |
   Then the HTTP status code of responses on all endpoints should be "404"                                  # FeatureContext::theHTTPStatusCodeOfResponsesOnAllEndpointsShouldBe()
     Responses did not return expected http status code
     Failed asserting that 409 is identical to 404.

Fails on this scenarios:

Scenario Outline: disabled user cannot use webdav                                      # /drone/src/tests/acceptance/features/coreApiWebdavOperations/refuseAccess.feature:26
    Given using <dav-path-version> DAV path                                              # FeatureContext::usingOldOrNewDavPath()
    And user "Alice" has been created with default attributes and without skeleton files # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "textfile0.txt"  # FeatureContext::userHasUploadedAFileTo()
    And user "Alice" has been disabled                                                   # FeatureContext::adminHasDisabledUserUsingTheProvisioningApi()
    When user "Alice" downloads file "/textfile0.txt" using the WebDAV API               # FeatureContext::userDownloadsFileUsingTheAPI()
    Then the HTTP status code should be "401"                                            # FeatureContext::thenTheHTTPStatusCodeShouldBe()

    Examples:
      | dav-path-version |
      | old              |
        Failed step: And user "Alice" has been disabled
        The HTTP status code 404 is not between 200 and 299
        Failed asserting that 404 is equal to 299 or is less than 299.
      | new              |
        Failed step: And user "Alice" has been disabled
        The HTTP status code 404 is not between 200 and 299
        Failed asserting that 404 is equal to 299 or is less than 299.
      | spaces           |
        Failed step: And user "Alice" has been disabled
        The HTTP status code 404 is not between 200 and 299
        Failed asserting that 404 is equal to 299 or is less than 299.

Please check in other repo for existence of closed issue i.e

To run the script:
Example:

GITHUB_ACCESS_TOKEN=<your_github_access_token> EXPECTED_FAILURES_FILE=<path_to_expected_to_failure_md_file> bash tests/acceptance/lint-closed-issue.sh

PR: https://github.com/owncloud/core/pull/40377/files

@SwikritiT
Copy link

Note that the test linked to this issue owncloud/ocis#904 might be failing now because of owncloud/web#4677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants