Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit page re-appears in loop when logged in user is deleted #4677

Open
swoichha opened this issue Feb 2, 2021 · 4 comments · Fixed by #7072 or #8947
Open

Exit page re-appears in loop when logged in user is deleted #4677

swoichha opened this issue Feb 2, 2021 · 4 comments · Fixed by #7072 or #8947
Labels
Priority:p4-low Low priority Type:Bug Something isn't working

Comments

@swoichha
Copy link
Contributor

swoichha commented Feb 2, 2021

Steps to reproduce

  1. create a new user and login
  2. delete the logged-in user
  3. Reload the page as logged in user
  4. The user should be redirected to an error page
  5. The user press exit to log in with another account

Expected behavior

  • The user should be redirected to the login page

Actual behavior

  • Instead of login page, the exit page re-appears.

Screenshot from 2021-02-02 12-01-59

@swoichha swoichha added the Type:Bug Something isn't working label Feb 2, 2021
@swoichha swoichha changed the title Exit page re-appears in loop for deleted user Exit page re-appears in loop when logged in user is deleted Feb 2, 2021
@kulmann kulmann added the Priority:p4-low Low priority label Dec 3, 2021
@AlexAndBear
Copy link
Contributor

Actual behavior differs a little:
You will be redirected to the Login Error page, clicking on exit, doesn't trigger any action.
After reloading you will be stuck in the Authentication failed page.

Unfortunately, #7072 does not fix the problem.

Reopening...

@AlexAndBear
Copy link
Contributor

Might be related: owncloud/ocis#3521

@rhafer
Copy link

rhafer commented May 17, 2023

I believe this is not fully fixed. I can't get back to the login page. Always get redirected to an error page:

2023-05-17.16-06-22.mp4

BTW this issue is also still mentioned in the expected failures even though it was closed:
https://github.com/owncloud/web/blob/master/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md?plain=1#LL12C1-L14C1

@JammingBen
Copy link
Collaborator

JammingBen commented Dec 13, 2023

Hitting a dead end here. There seems to be some issue when trying to unload the user in case of an error. For some reason, the state/storage doesn't get cleared properly.

I digged deep into the oidc lib, but the only way I found to make it clean properly is to call signoutRedirect, which eventually redirects the user to the login page. Hence we would lose the accessDenied page. You can specify another URL to route to after logout, but that doesn't work either. I'm out of ideas honestly...

Same issue: #9562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p4-low Low priority Type:Bug Something isn't working
Projects
Status: Prio 3 or less
Status: Bugs Prio 3 or less
Development

Successfully merging a pull request may close this issue.

5 participants