Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] make user enable disable feature use graphapi #6790

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jul 13, 2023

Description

The steps where admin disable any user issue were marked failed as it uses OCS API. At present, this task couldn't be done using ocs API as the curl request to that endpoint results in an error. This PR redacted that step so that the feature now uses graph API and the Scenario gets passed and they were removed from the expected failure file.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta marked this pull request as ready for review July 13, 2023 06:14
@S-Panta S-Panta self-assigned this Jul 13, 2023
@S-Panta S-Panta marked this pull request as draft July 13, 2023 06:16
@S-Panta S-Panta force-pushed the enable-disable-user-graphapi branch 2 times, most recently from 64559ae to b9c21e7 Compare July 13, 2023 09:01
@S-Panta S-Panta marked this pull request as ready for review July 13, 2023 09:04
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test runs in reva. so need to find better way

@S-Panta S-Panta force-pushed the enable-disable-user-graphapi branch 2 times, most recently from 668b828 to 55090a2 Compare July 18, 2023 05:49
@S-Panta S-Panta force-pushed the enable-disable-user-graphapi branch from 55090a2 to 77dee2c Compare July 18, 2023 08:38
@S-Panta S-Panta requested review from saw-jan and SagarGi July 19, 2023 03:43
@S-Panta S-Panta force-pushed the enable-disable-user-graphapi branch 2 times, most recently from 2a6b282 to bdfa438 Compare July 19, 2023 09:44
@S-Panta S-Panta force-pushed the enable-disable-user-graphapi branch from bdfa438 to fd61ba5 Compare July 19, 2023 11:14
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan requested a review from SagarGi July 20, 2023 06:12
@saw-jan saw-jan merged commit bed8c77 into master Jul 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the enable-disable-user-graphapi branch July 20, 2023 08:42
ownclouders pushed a commit that referenced this pull request Jul 20, 2023
…6790)

* make user enable disable feature use graphapi

* change the step definition code for user disable action

* updated step definition code for user disable feature

* updated user disable implementation

* corrected the error of step implementation code
ownclouders pushed a commit that referenced this pull request Jul 21, 2023
…6790)

* make user enable disable feature use graphapi

* change the step definition code for user disable action

* updated step definition code for user disable feature

* updated user disable implementation

* corrected the error of step implementation code
ownclouders pushed a commit that referenced this pull request Jul 22, 2023
…6790)

* make user enable disable feature use graphapi

* change the step definition code for user disable action

* updated step definition code for user disable feature

* updated user disable implementation

* corrected the error of step implementation code
SwikritiT pushed a commit that referenced this pull request Aug 21, 2023
…6790)

* make user enable disable feature use graphapi

* change the step definition code for user disable action

* updated step definition code for user disable feature

* updated user disable implementation

* corrected the error of step implementation code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants