Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] make user enable disable feature use graphapi #7077

Closed
wants to merge 1 commit into from

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Aug 21, 2023

backport #6790

Description

The steps where admin disable any user issue were marked failed as it uses OCS API. At present, this task couldn't be done using ocs API as the curl request to that endpoint results in an error. This PR redacted that step so that the feature now uses graph API and the Scenario gets passed and they were removed from the expected failure file.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

…6790)

* make user enable disable feature use graphapi

* change the step definition code for user disable action

* updated step definition code for user disable feature

* updated user disable implementation

* corrected the error of step implementation code
@SwikritiT SwikritiT self-assigned this Aug 21, 2023
@SwikritiT SwikritiT changed the title [tests-only][full-ci] make user enable disable feature use graphapi (… [tests-only][full-ci] make user enable disable feature use graphapi Aug 21, 2023
@SwikritiT SwikritiT marked this pull request as ready for review August 21, 2023 08:49
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment on lines -627 to -628
### [graph/users: enable/disable users](https://github.com/owncloud/ocis/issues/3064)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests fail in stable because of this #7087 but if the fix won't be backported to stable we can also skip these tests in stable. waiting for some decision on what to do

@SwikritiT
Copy link
Contributor Author

Since we decided we won't maintain stable-3.0 and this changes already exist in stable-4.0 closing this PR

@SwikritiT SwikritiT closed this Sep 1, 2023
@SwikritiT SwikritiT deleted the backport/6790 branch September 1, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants