Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify service vs. extension #3926

Closed
butonic opened this issue Jun 7, 2022 · 5 comments · Fixed by #3980
Closed

clarify service vs. extension #3926

butonic opened this issue Jun 7, 2022 · 5 comments · Fixed by #3980
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@butonic
Copy link
Member

butonic commented Jun 7, 2022

When going over the dev docs @mmattel noticed that I was referring to ocdav as a service, whereas most places use the term extension. Even the folder containing all ocis extensions / services is called extensions. But what are we extending? The ocis platform? Currently, the ocis extensions provide the core functionality of ocis. There is a difference between these core extensions and actual extensions like a calender or contacts extension.

@C0rby pointed out that all extensions we currently have are actually not really extensions, but services that make up the ocis platform.

While we could keep calling all ocis services extensions it would be clearer to call them ocis services. That would allow distinguishing them from ocis extensions which extend the ocis platform that in turn consists of at least the set of ocis services.

Would that mean we rename the extensions folder to services?

@micbar @dragotin @dragonchaser @C0rby @kobergj @owncloud/pm thoughts?

@mmattel
Copy link
Contributor

mmattel commented Jun 7, 2022

Any clearance we make now, will avoid confusion and creative/challenging "explanations" later on.

@dragonchaser
Copy link
Member

Renaming extensions => services makes sense to me, in the future we could add a new extensions directory where we pin third-party extensions we want to bundle using git sub-modules.

@C0rby
Copy link
Contributor

C0rby commented Jun 7, 2022

I support renaming extensions to services.

@dragotin
Copy link
Contributor

dragotin commented Jun 7, 2022

So far, AFAIK we only have services that are bundled by default and make the functionality of oCIS. Extensions are optional for me, and could be maintained elsewhere as @dragonchaser says.

So I support the rename as well.

@pmaier1
Copy link
Contributor

pmaier1 commented Jun 13, 2022

I agree with the arguments in the OP and support the rename as well.

@dragonchaser dragonchaser added the Priority:p2-high Escalation, on top of current planning, release blocker label Jun 17, 2022
@dragonchaser dragonchaser self-assigned this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants