Refactor extensions to services. #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dragonchaser
force-pushed
the
rename-extensions-to-services
branch
11 times, most recently
from
82c9a64
to
fdae5f4
Compare
rhafer
requested review from
wkloucek,
micbar,
phil-davis,
individual-it,
kulmann and
pascalwengerter
as code owners
dragonchaser
force-pushed
the
rename-extensions-to-services
branch
2 times, most recently
from
9adb72d
to
6884e22
Compare
|
💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled... |
dragonchaser
changed the title
dragonchaser
force-pushed
the
rename-extensions-to-services
branch
2 times, most recently
from
198b7eb
to
8f74066
Compare
dragonchaser
force-pushed
the
rename-extensions-to-services
branch
2 times, most recently
from
c3289cd
to
7d1c8fa
Compare
dragonchaser
force-pushed
the
rename-extensions-to-services
branch
5 times, most recently
from
c7fad7b
to
97a16b8
Compare
wkloucek
approved these changes
Jun 23, 2022
9 tasks
|
@dragonchaser @wkloucek is it OK to merge this? Or does it need to be merged at some specific time to avoid creating "havoc" for other developers and releases? |
micbar
previously requested changes
Jun 23, 2022
|
@phil-davis && @micbar we suggest rebasing & merging this tomorrow afternoon (around 3PM CET) to avoid greater chaos 💥 |
dragonchaser
force-pushed
the
rename-extensions-to-services
branch
4 times, most recently
from
13697f2
to
fe8cb48
Compare
|
do not merge before .beta4 is released! |
wkloucek
requested changes
Jun 27, 2022
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
force-pushed
the
rename-extensions-to-services
branch
from
fe8cb48
to
0ebfb89
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
wkloucek
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided to name all extensions, we maintain and provide with ocis,
services from here on to avoid confusion between external extensions and code
we provide and maintain.
fixes: #3926
/cc @mmattel