-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some env content provided does not make it into the documentation #4097
Comments
@mmattel looks like the default value is not properly escaped: https://github.com/owncloud/ocis/blame/docs/services/_includes/adoc/frontend_configvars.adoc#L289-L294 Could you please give a properly escaped example for this? |`FRONTEND_CHECKSUMS_SUPPORTED_TYPES`
|
a| [subs=-attributes]
[sha1 md5 adler32]
a| [subs=-attributes]
Supported checksum types to be announced to the client (e.g. md5) EDIT: |`THUMBNAILS_RESOLUTIONS`
|
a| [subs=-attributes]
[16x16 32x32 64x64 128x128 1920x1080 3840x2160 7680x4320]
a| [subs=-attributes]
The supported target resolutions in the format WidthxHeight e.g. 32x32. You can provide multiple resolutions separated by a comma. |
could it be related to the fact that both fields are slices ( |
Found the issue 😅 we need to adapt the adoc export. Reason Solution 1
Example replacement (note the leading and trailing blanks): No replacement would be when (blank between bracket and character): Solution 2 Solution 1 requires adaption of the rules which is more effort I will create a PR with solution 2 and @dragonchaser will do a local render test and checks the output for success. |
We need to add a specific regexp to solve this here: https://github.com/owncloud/ocis/blob/master/docs/helpers/adoc-generator.go.tmpl#L97 to replace |
Fixes: #4097 (Some env content provided does not make it into the documentation) Adding the `pass` macro for those two cells is neccessary because the content are go slices (arrays) which would be interpreted differently in Antora.
There seems to be an issue that some content that is present here in the repo does not make it into the documentation.
screenshot provided by @dragonchaser
outcome on the web (admin docs)
As you can see, the type and the default are missing, while the description is present.
Another one is
FRONTEND_CHECKSUMS_SUPPORTED_TYPES
where type and the default are missing too.It seems that something (tm) is happening inbetween the source and the generated adoc table. admin docs does nothing with it and just includes that file.
The text was updated successfully, but these errors were encountered: