Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language setting for the app provider #4367

Closed
wkloucek opened this issue Aug 9, 2022 · 2 comments · Fixed by #4399
Closed

Language setting for the app provider #4367

wkloucek opened this issue Aug 9, 2022 · 2 comments · Fixed by #4399
Assignees
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Story User Story

Comments

@wkloucek
Copy link
Contributor

wkloucek commented Aug 9, 2022

Is your feature request related to a problem? Please describe.

Opening a file with the app provider does not use the language of oC Web because there is currently no way to pass the language as a parameter.

Describe the solution you'd like

oC Web passes a parameter to the /app/open endpoint with the language, the use has configured for oC Web.
The language option will then be added eg. to the WOPI open parameters (UI_LLCC / lang) or the respective parameter for other apps (but transparent to oC Web).

If the language is not provided, the current default applies. Currently some apps try to detect the primary language of the browser, other apps have hardcoded defaults.

Describe alternatives you've considered

oC Web injects the language into the apps directly. Downside is that oC Web needs to do how to do it for every app.

Additional context

@micbar micbar added Priority:p1-urgent Consider a hotfix release with only that fix and removed p3-medium labels Aug 10, 2022
@micbar micbar added this to the 2.0.0 General Availability milestone Aug 10, 2022
@kulmann
Copy link
Member

kulmann commented Aug 11, 2022

If you can decide the naming of the additional param for the open request we can already pass it from web.

@wkloucek
Copy link
Contributor Author

If you can decide the naming of the additional param for the open request we can already pass it from web.

I created PRs in REVA and oCIS that will add the lang parameter documented here: https://github.com/owncloud/ocis/blob/1646b0b5af98747d16d0a54c200f437254f435d9/docs/services/app-registry/apps.md#open-a-file-with-the-app-provider (coming from #4399)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Story User Story
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants