Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add language selection for app provider #4399

Merged
merged 2 commits into from
Aug 18, 2022
Merged

add language selection for app provider #4399

merged 2 commits into from
Aug 18, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Aug 16, 2022 •
edited
Loading

Description

Enhancement: Added language option to the app provider

We've added an language option to the app provider which will in the
end be passed to the app a user opens so that the web ui is displayed in the users language.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

This was referenced Aug 16, 2022
Merged
Closed
@wkloucek wkloucek marked this pull request as ready for review August 17, 2022 12:11
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found a typo in the changelog item. But looks good 👍

changelog/unreleased/enhancement-app-provider-language-selection.md Outdated Show resolved Hide resolved
@wkloucek @kulmann
fix typo
771e7e8 
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
@wkloucek wkloucek merged commit a3f7768 into owncloud:master Aug 18, 2022
@wkloucek wkloucek deleted the language-selection-for-app-provider branch August 18, 2022 09:49
ownclouders pushed a commit that referenced this pull request Aug 18, 2022
@wkloucek
commit a3f7768
a2ab579 
Merge: c271c9a 771e7e8
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu Aug 18 11:49:23 2022 +0200

    Merge pull request #4399 from wkloucek/language-selection-for-app-provider

    add language selection for app provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@kobergj kobergj Awaiting requested review from kobergj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language setting for the app provider
3 participants
@wkloucek @ownclouders @kulmann