Make the virtual "Shares" Space permanent

[michaelstingl]

Is your feature request related to a problem? Please describe.

Having the virtual "Shares" Spaces appear and disappear all the time is a horrible user experience for users of the desktop client.

The biggest problems:

1) New account, where user didn't receive or didn't accept a share yet

Current desktop app doesn't add new Spaces dynamically and doesn't notify users about new, available Spaces. Only when setting up a new account, all available Spaces get synced locally. When virtual "Shares" Space isn't available from the beginning, some users will probably never find their received Shares.

2) User declines the last share or got removed from a share

This leaves the desktop app in a very weird state:

• [QA] Last deleted Share remains present locally  client#10278
• [QA] Exmembers have spaces saved locally client#10285

Describe the solution you'd like

Virtual "Shares" Space should be permanent from the first time a user connects, and should never disappear later.

Describe alternatives you've considered

I thought about workaround hacks in the desktop app, but this doesn't sound useful.

Additional context

Empty, permanent virtual "Shares" Space got removed, I think because of difficulties with eTags.

@micbar I'd like to discuss this again

/cc @HanaGemela @TheOneRing @tbsbdr

[micbar]

Empty, permanent virtual "Shares" Space got removed, I think because of difficulties with eTags.

It was removed on request of some team, I don't remember exactly why. Let us make a decision before we add / remove this on regular intervals 🙈

[micbar]

Decision was made:

1. We need to always have the Share Jail present on the graph and webDav endpoints.
2. Empty Share Jail needs a hardcoded eTag.

@TheOneRing @felix-schwarz Can you propose a format/length for the hardcoded eTag

[felix-schwarz]

@micbar As far as iOS is concerned, you can pick any eTag. Format/length doesn't matter to it.

[TheOneRing]

I agree with @felix-schwarz

[C0rby]

@TheOneRing @felix-schwarz
Here is what I have so far:

curl -s -k -u admin:admin https://localhost:9200/graph/v1.0/me/drives | jq .
{
  "value": [
    {
      "driveAlias": "personal/admin",
      "driveType": "personal",
      "id": "a22e9474-88b5-45d4-9692-69be6eaa5b69$88c85652-76d0-4265-bbb3-56cf474186ae",
      "lastModifiedDateTime": "2022-12-22T10:24:13.069518955+01:00",
      "name": "Admin",
      "owner": {
        "user": {
          "id": "88c85652-76d0-4265-bbb3-56cf474186ae"
        }
      },
      "quota": {
        "remaining": 235721998336,
        "state": "normal",
        "total": 0,
        "used": 0
      },
      "root": {
        "eTag": "\"eae44aa8f9aab8e76e0b5f2a652ce63a\"",
        "id": "a22e9474-88b5-45d4-9692-69be6eaa5b69$88c85652-76d0-4265-bbb3-56cf474186ae",
        "webDavUrl": "https://localhost:9200/dav/spaces/a22e9474-88b5-45d4-9692-69be6eaa5b69$88c85652-76d0-4265-bbb3-56cf474186ae"
      },
      "webUrl": "https://localhost:9200/f/a22e9474-88b5-45d4-9692-69be6eaa5b69$88c85652-76d0-4265-bbb3-56cf474186ae"
    },
    {
      "driveAlias": "virtual/shares",
      "driveType": "virtual",
      "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668",
      "name": "Shares",
      "quota": {
        "remaining": 0,
        "state": "exceeded",
        "total": 0,
        "used": 0
      },
      "root": {
        "eTag": "DECAFC00FEE",
        "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668",
        "webDavUrl": "https://localhost:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668"
      },
      "webUrl": "https://localhost:9200/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668"
    }
  ]
}

If that is all that is needed I'll open up a PR or do you need any more changes?

[TheOneRing]

"eTag": "DECAFC00FEE", you're disgusting 😜

[C0rby]

Reva PR is here: cs3org/reva#3569

[felix-schwarz]

I agree that DECAFBAD and think BADEAFFE would have been more fun, but I don't think it's BADC0DED because of that. 🤪

Looks good to me!

[micbar]

Needs reva update.

[michaelstingl]

Looks good on https://ocis.ocis-traefik.latest.owncloud.works/

ownCloud Web UI 7.0.0-rc.11 
Infinite Scale 2.0.0+26f7523ff Community