Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid propfind response for sharejail #5711

Closed
TheOneRing opened this issue Mar 2, 2023 · 8 comments
Closed

Invalid propfind response for sharejail #5711

TheOneRing opened this issue Mar 2, 2023 · 8 comments
Labels

Comments

@TheOneRing
Copy link
Member

Describe the bug

A clear and concise description of what the bug is.

Steps to reproduce

Steps to reproduce the behavior:

  1. Connect the desktop service to a ocis instance with keycloak
  2. Revoke the token
  3. Wait for a sync or force one

Expected behavior

A clear and concise description of what you expected to happen.
I'd expect a 401 or any other error response on the propfind

Actual behavior

A clear and concise description of what happened.
I receive a 207 and a malformed (no etag) response from the server.

23-03-01 16:35:23:567 [ info sync.httplogger ]:	"1b265148-6152-4ccf-98b0-3edc811b46aa: Response: PROPFIND 207 (16ms) https://ocis.owncloud.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/ Header: { Access-Control-Allow-Origin: *, Access-Control-Expose-Headers: Tus-Resumable, Tus-Version, Tus-Extension, Content-Length: 241, Content-Security-Policy: default-src 'none';, Content-Type: application/xml; charset=utf-8, Date: Wed, 01 Mar 2023 15:35:23 GMT, Dav: 1, 3, extended-mkcol, Preference-Applied: return=minimal, Tus-Extension: creation,creation-with-upload,checksum,expiration, Tus-Resumable: 1.0.0, Tus-Version: 1.0.0, Vary: Prefer, X-Content-Type-Options: nosniff, X-Download-Options: noopen, X-Frame-Options: SAMEORIGIN, X-Permitted-Cross-Domain-Policies: none, X-Robots-Tag: none, X-Xss-Protection: 1; mode=block, } Data: [<d:multistatus xmlns:s=\"http://sabredav.org/ns\" xmlns:d=\"DAV:\" xmlns:oc=\"http://owncloud.org/ns\"><d:response><d:href>/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/</d:href></d:response></d:multistatus>]"

Setup

Please describe how you started the server and provide a list of relevant environment variables or configuration files.

Keycloak deployment example

Additional context

Add any other context about the problem here.

@wkloucek
Copy link
Contributor

wkloucek commented Mar 2, 2023

@TheOneRing
Copy link
Member Author

I think my assumption here was wrong.
I encountered the same issue during a normal sync, for a propfind on the sharejail.

[ info sync.httplogger ]:	"27911094-4251-4dd1-9451-cca9bdbf3a0c: Response: PROPFIND 207 (26ms) https://ocis.owncloud.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/ Header: { Access-Control-Allow-Origin: *, Access-Control-Expose-Headers: Tus-Resumable, Tus-Version, Tus-Extension, Content-Length: 241, Content-Security-Policy: default-src 'none';, Content-Type: application/xml; charset=utf-8, Date: Thu, 16 Mar 2023 10:02:40 GMT, Dav: 1, 3, extended-mkcol, Preference-Applied: return=minimal, Tus-Extension: creation,creation-with-upload,checksum,expiration, Tus-Resumable: 1.0.0, Tus-Version: 1.0.0, Vary: Prefer, X-Content-Type-Options: nosniff, X-Download-Options: noopen, X-Frame-Options: SAMEORIGIN, X-Permitted-Cross-Domain-Policies: none, X-Robots-Tag: none, X-Xss-Protection: 1; mode=block, } Data: [<d:multistatus xmlns:s=\"http://sabredav.org/ns\" xmlns:d=\"DAV:\" xmlns:oc=\"http://owncloud.org/ns\"><d:response><d:href>/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/</d:href></d:response></d:multistatus>]"

@C0rby as far as I know I should get some "decaf" etag here?

@TheOneRing TheOneRing changed the title Invalid propfind response after oauth token was revoked in keycloak Invalid propfind response for sharejail Mar 16, 2023
@C0rby
Copy link
Contributor

C0rby commented Mar 16, 2023

Which oCIS version are you using?
When I'm doing a PROPFIND on the current master then I get the following response:

$ curl -s -k -u admin:admin -X PROPFIND 'https://localhost:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668'  | xmllint --format -
<?xml version="1.0"?>
<d:multistatus xmlns:s="http://sabredav.org/ns" xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!a0ca6a90-a365-4782-871e-d44447bbc668</oc:id>
        <oc:fileid>a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!a0ca6a90-a365-4782-871e-d44447bbc668</oc:fileid>
        <oc:spaceid>a0ca6a90-a365-4782-871e-d44447bbc668</oc:spaceid>
        <oc:shareid/>
        <d:getetag>"DECAFC00FEE"</d:getetag>
        <oc:permissions/>
        <d:resourcetype>
          <d:collection/>
        </d:resourcetype>
        <oc:size>0</oc:size>
        <oc:favorite>0</oc:favorite>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
    <d:propstat>
      <d:prop>
        <oc:file-parent/>
      </d:prop>
      <d:status>HTTP/1.1 404 Not Found</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

@TheOneRing
Copy link
Member Author

Infinite Scale 2.0.0+0013690d0 Community

@michaelstingl
Copy link
Contributor

I receive a 207 and a malformed (no etag) response from the server.

Related:

@C0rby
Copy link
Contributor

C0rby commented Mar 16, 2023

Infinite Scale 2.0.0+0013690d0 Community

Yeah this version doesn't contain the etag fix yet.

@TheOneRing
Copy link
Member Author

Oh ok, pulled today and your fix was merged January the first...

@TheOneRing
Copy link
Member Author

Duplicate of #5591

@TheOneRing TheOneRing marked this as a duplicate of #5591 Mar 17, 2023
@TheOneRing TheOneRing closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants