Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dynamic client registration #5498

Closed
butonic opened this issue Feb 1, 2023 · 6 comments
Closed

support dynamic client registration #5498

butonic opened this issue Feb 1, 2023 · 6 comments

Comments

@butonic
Copy link
Member

butonic commented Feb 1, 2023

We currently hardcoded the default client identifiers for openid connect because lico disabled it by default: #2026

When trying to develop a new client for ocis developers would like to use OpenID Connect Dynamic Client Registration OOTB.

@butonic
Copy link
Member Author

butonic commented Feb 1, 2023

It is possible to enable dynamic client registration by setting IDP_ALLOW_DYNAMIC_CLIENT_REGISTRATION=true. But when testing with our clients we encountered some problems. Maybe @michaelstingl can elaborate.

@butonic
Copy link
Member Author

butonic commented Feb 1, 2023

There is a huge docs issue trying to sort out what should be documented: owncloud/docs#3499

@butonic
Copy link
Member Author

butonic commented Feb 1, 2023

The problems seem to have been caused by the client registration expiring after an hour. They no longer expire, but this can be reenabled by setting IDP_DYNAMIC_CLIENT_SECRET_DURATION if desired.

@michaelstingl
Copy link
Contributor

michaelstingl commented Feb 2, 2023

Desktop + mobile apps DCR when announced in /.well-known/openid-configuration, and when it fails, they fall back to client id + secret.

@stale
Copy link

stale bot commented Apr 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Apr 5, 2023
@stale stale bot closed this as completed Apr 25, 2023
@micbar
Copy link
Contributor

micbar commented Apr 25, 2023

DCR works with the example ocis deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants