Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic client registration changes #2026

Merged
merged 3 commits into from
May 18, 2021
Merged

dynamic client registration changes #2026

merged 3 commits into from
May 18, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 6, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 6, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

michaelstingl
michaelstingl suggested changes May 6, 2021
View reviewed changes
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems client names got lost in some places

idp/assets/identifier-registration.yaml Show resolved Hide resolved
deployments/examples/owncloud10_with_oc_web/config/ocis/identifier-registration.dist.yaml Show resolved Hide resolved
deployments/examples/owncloud10_with_oc_web/config/ocis/identifier-registration.dist.yaml Show resolved Hide resolved
@wkloucek wkloucek marked this pull request as ready for review May 7, 2021 06:34
@wkloucek wkloucek requested review from michaelstingl, refs and C0rby May 7, 2021 06:39
michaelstingl
michaelstingl approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me, but I'm not really a Keycloak or Golang expert

@wkloucek wkloucek requested a review from LukasHirt as a code owner May 18, 2021 06:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 9b753d5 into master May 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the dcr_changes branch May 18, 2021 07:35
ownclouders pushed a commit that referenced this pull request May 18, 2021
@wkloucek
commit 9b753d5
4d946b7 
Merge: 0f377ca 53739f1
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue May 18 09:35:42 2021 +0200

    Merge pull request #2026 from owncloud/dcr_changes

    dynamic client registration changes
@wkloucek wkloucek mentioned this pull request May 19, 2021
Merged
@butonic butonic mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstingl michaelstingl michaelstingl approved these changes

@refs refs Awaiting requested review from refs

@C0rby C0rby Awaiting requested review from C0rby

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @michaelstingl