Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sharejail space sometimes has no etag set #7160

Closed
butonic opened this issue Aug 30, 2023 · 3 comments · Fixed by #7178
Closed

sharejail space sometimes has no etag set #7160

butonic opened this issue Aug 30, 2023 · 3 comments · Fixed by #7178
Labels
Type:Bug

Comments

@butonic
Copy link
Member

butonic commented Aug 30, 2023 •
edited
Loading

In the sharesstoragprovider

if earliestShare != nil {
	if info, ok := shareInfo[earliestShare.GetId().GetOpaqueId()]; ok {
		mtime = info.Mtime
		opaque = utils.AppendPlainToOpaque(opaque, "etag", info.Etag)
	} // FIXME how can this happen??? the desktop is seeing a share jail space without an etag
} else {
	opaque = utils.AppendPlainToOpaque(opaque, "etag", _defaultSharesJailEtag)
}
@TheOneRing
Copy link
Member 

{
  "value": [
    {
      "driveAlias": "personal/einstein",
      "driveType": "personal",
      "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$4c510ada-c86b-4815-8820-42cdf82c3d51",
      "lastModifiedDateTime": "2023-08-25T07:08:59.541395451Z",
      "name": "Albert Einstein",
      "owner": {
        "user": {
          "displayName": "",
          "id": "4c510ada-c86b-4815-8820-42cdf82c3d51"
        }
      },
      "quota": {
        "remaining": 965635379200,
        "state": "normal",
        "total": 0,
        "used": 187417012
      },
      "root": {
        "eTag": "\"71bcdb598680829a8e5af778e55d110e\"",
        "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$4c510ada-c86b-4815-8820-42cdf82c3d51",
        "webDavUrl": "https://ocis.owncloud.test/dav/spaces/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$4c510ada-c86b-4815-8820-42cdf82c3d51"
      },
      "webUrl": "https://ocis.owncloud.test/f/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$4c510ada-c86b-4815-8820-42cdf82c3d51"
    },
    {
      "driveAlias": "virtual/shares",
      "driveType": "virtual",
      "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668",
      "name": "Shares",
      "root": {
        "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668",
        "webDavUrl": "https://ocis.owncloud.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668"
      },
      "webUrl": "https://ocis.owncloud.test/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668"
    },
    {
      "description": "Flower power",
      "driveAlias": "project/new-space",
      "driveType": "project",
      "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26",
      "lastModifiedDateTime": "2023-08-24T13:23:49.713215204Z",
      "name": "Gardening",
      "owner": {
        "user": {
          "displayName": "",
          "id": "223cf67a-d703-4ba4-9991-0e3937b66f26"
        }
      },
      "quota": {
        "remaining": 999579266,
        "state": "normal",
        "total": 1000000000,
        "used": 420734
      },
      "root": {
        "eTag": "\"f0f88444a7184d29b1dd4d3b7baab5b6\"",
        "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26",
        "permissions": [
          {
            "grantedToIdentities": [
              {
                "user": {
                  "displayName": "Albert Einstein",
                  "id": "4c510ada-c86b-4815-8820-42cdf82c3d51"
                }
              }
            ],
            "roles": [
              "viewer"
            ]
          },
          {
            "grantedToIdentities": [
              {
                "user": {
                  "displayName": "Katherine Johnson",
                  "id": "534bb038-6f9d-4093-946f-133be61fa4e7"
                }
              }
            ],
            "roles": [
              "manager"
            ]
          }
        ],
        "webDavUrl": "https://ocis.owncloud.test/dav/spaces/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26"
      },
      "special": [
        {
          "eTag": "\"bce193f9408a1ba36b96ccd12c3e3a58\"",
          "file": {
            "mimeType": "image/jpeg"
          },
          "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26!69573ab4-0489-4271-aa36-8fa5872a3990",
          "lastModifiedDateTime": "2023-08-24T13:22:14.000000799Z",
          "name": "133602.jpg",
          "size": 420676,
          "specialFolder": {
            "name": "image"
          },
          "webDavUrl": "https://ocis.owncloud.test/dav/spaces/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26%21223cf67a-d703-4ba4-9991-0e3937b66f26/.space/133602.jpg"
        },
        {
          "eTag": "\"3b6d43af194335b94dc210676c080b14\"",
          "file": {
            "mimeType": "text/markdown"
          },
          "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26!39885ca5-a4c2-4d72-8adc-b2827025c4bc",
          "lastModifiedDateTime": "2023-07-06T12:16:06.963701Z",
          "name": "readme.md",
          "size": 46,
          "specialFolder": {
            "name": "readme"
          },
          "webDavUrl": "https://ocis.owncloud.test/dav/spaces/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26%21223cf67a-d703-4ba4-9991-0e3937b66f26/.space/readme.md"
        }
      ],
      "webUrl": "https://ocis.owncloud.test/f/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26"
    },
    {
      "driveAlias": "mountpoint/share1",
      "driveType": "mountpoint",
      "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:534bb038-6f9d-4093-946f-133be61fa4e7:8f1b4c85-8413-4cbe-86b0-ddca79f7c7d0",
      "name": "Share1",
      "owner": {
        "user": {
          "displayName": "",
          "id": "534bb038-6f9d-4093-946f-133be61fa4e7"
        }
      },
      "root": {
        "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:534bb038-6f9d-4093-946f-133be61fa4e7:8f1b4c85-8413-4cbe-86b0-ddca79f7c7d0",
        "remoteItem": {
          "driveAlias": "personal/katherine",
          "eTag": "\"da8e5d4804c4890c5a099b3351e2ce6c\"",
          "folder": {},
          "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$534bb038-6f9d-4093-946f-133be61fa4e7!7cd0a3cd-8f7f-49a0-9f10-af117f0f6429",
          "lastModifiedDateTime": "2023-08-24T12:32:17.242157438Z",
          "name": "Share1",
          "path": "/Share1",
          "rootId": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$534bb038-6f9d-4093-946f-133be61fa4e7!534bb038-6f9d-4093-946f-133be61fa4e7",
          "size": 6,
          "webDavUrl": "https://ocis.owncloud.test/dav/spaces/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$534bb038-6f9d-4093-946f-133be61fa4e7%21534bb038-6f9d-4093-946f-133be61fa4e7/Share1"
        },
        "webDavUrl": "https://ocis.owncloud.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668%21193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:534bb038-6f9d-4093-946f-133be61fa4e7:8f1b4c85-8413-4cbe-86b0-ddca79f7c7d0"
      },
      "webUrl": "https://ocis.owncloud.test/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668%21193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:534bb038-6f9d-4093-946f-133be61fa4e7:8f1b4c85-8413-4cbe-86b0-ddca79f7c7d0"
    },
    {
      "driveAlias": "mountpoint/child-write",
      "driveType": "mountpoint",
      "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:223cf67a-d703-4ba4-9991-0e3937b66f26:200852ff-637b-4360-8dc5-e24616dd8ed6",
      "name": "Child-Write",
      "owner": {
        "user": {
          "displayName": "",
          "id": "223cf67a-d703-4ba4-9991-0e3937b66f26"
        }
      },
      "root": {
        "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:223cf67a-d703-4ba4-9991-0e3937b66f26:200852ff-637b-4360-8dc5-e24616dd8ed6",
        "remoteItem": {
          "driveAlias": "project/new-space",
          "eTag": "\"5384fda8e1ffeefb84e59eb1fbd6a792\"",
          "folder": {},
          "id": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26!9a5a099d-de5f-4901-affc-229335273b51",
          "lastModifiedDateTime": "2023-08-09T09:20:56.459324936Z",
          "name": "Child-Write",
          "path": "/Parent-Read/Child-Write",
          "rootId": "193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26!223cf67a-d703-4ba4-9991-0e3937b66f26",
          "size": 4,
          "webDavUrl": "https://ocis.owncloud.test/dav/spaces/193f78ba-ad9f-4e1b-b53b-8e336f4b37d6$223cf67a-d703-4ba4-9991-0e3937b66f26%21223cf67a-d703-4ba4-9991-0e3937b66f26/Parent-Read/Child-Write"
        },
        "webDavUrl": "https://ocis.owncloud.test/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668%21193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:223cf67a-d703-4ba4-9991-0e3937b66f26:200852ff-637b-4360-8dc5-e24616dd8ed6"
      },
      "webUrl": "https://ocis.owncloud.test/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668%21193f78ba-ad9f-4e1b-b53b-8e336f4b37d6:223cf67a-d703-4ba4-9991-0e3937b66f26:200852ff-637b-4360-8dc5-e24616dd8ed6"
    }
  ]
}

@TheOneRing
Copy link
Member

I can't spot a pattern, some responses are valid and some are not.

TheOneRing added a commit to owncloud/client that referenced this issue Aug 30, 2023
@TheOneRing
Handle missing etag bug owncloud/ocis#7160
650927c
@kobergj kobergj mentioned this issue Aug 30, 2023
Merged
@kobergj
Copy link
Collaborator

kobergj commented Aug 30, 2023

Found the issue: When having a pending share first in the receivedShares list, the sharestorageprovider will always omit mtime and etag. Fix needs a roundtrip through reva

TheOneRing added a commit to owncloud/client that referenced this issue Aug 30, 2023
@TheOneRing
Handle missing etag bug owncloud/ocis#7160
dfca9fd
@kobergj kobergj mentioned this issue Aug 31, 2023
Merged
@SwikritiT SwikritiT mentioned this issue Oct 12, 2023
Closed
@SwikritiT SwikritiT mentioned this issue Oct 19, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[full-ci] Bump Reva kobergj/ocis
3 participants
@TheOneRing @butonic @kobergj