[test-only] Reworking lock tests

[ScharfViktor]

I started to rework lock tests, see here #7595 and #7624

need rework tests from:

• tests/acceptance/features/coreApiWebdavLocks [tests-only][full-ci]Move locks related tests to local api tests and link the failing lock tests with correct issues #7643
• tests/acceptance/features/coreApiWebdavLocks2 [tests-only][full-ci]Move locks related tests to local api tests and link the failing lock tests with correct issues #7643
• tests/acceptance/features/coreApiWebdavLocksUnlock [tests-only][full-ci]Move unlock related tests from core to local api tests #7747 [tests-only][full-ci] move tests coreApiWebdavLocksUnlock/unlockSharingToShares.feature from to local api #7769

next test

• unlock file for project space @nabim777 [tests-only][full-ci] Add test for unlocking project space file #7698 Error 500 when user try to unlock project space file #7696
• unlock file using fileId (we need this test because onlyOffice uses it) @SwikritiT Error 500 when user try to unlock file using fileid #7708 [tests-only]tests: add tests for unlocking using file id #7780
• check if the lock expires @SwikritiT [tests-only][full-ci]tests: add tests for lock expiration #7777
• lock and unlock for public [tests-only][full-ci]tests: add test for lock/unlock in public link share #7789

collecting bug:

• Shared file locking is not possible using different path #7599
• 500 error if viewer tries to lock file #7600
• Trying to upload to a locked file gives 500  #7638
• Folders can be locked and locking works partially #7641
• Error 500 when user try to unlock project space file #7696
• Error 500 when user try to unlock file using fileid #7708
• Anonymous users can unlock a file shared to them through a public link if they get the lock token #7761
• Trying to unlock a shared file as a share reciever with sharer's lock token gives 500 #7767
• anonymous user with viewer role in public link of a folder can lock a file inside it #7785
• Anonymous user trying lock a file shared to them through a public link gives 405 #7790

CC @saw-jan

[SwikritiT]

The only feature remaining in tests/acceptance/features/coreApiWebdavLocks is https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavLocks/requestsWithToken.feature
which is failing because share lock is not implemented as described in #7599, @ScharfViktor I'll leave it as it is for now or would you recommend to move it as well?

[ScharfViktor]

The only feature remaining in tests/acceptance/features/coreApiWebdavLocks is https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavLocks/requestsWithToken.feature which is failing because share lock is not implemented as described in #7599, @ScharfViktor I'll leave it as it is for now or would you recommend to move it as well?

I guess this case won't work because sharee cannot shared resource if sharer already locked it. like this case: https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/lockFiles.feature#L219

[SwikritiT]

@ScharfViktor all the checklists have been done. Can you go through the tests and make sure that there is proper test coverage or mention if we need to add more tests?

[ScharfViktor]

@ScharfViktor all the checklists have been done. Can you go through the tests and make sure that there is proper test coverage or mention if we need to add more tests?

Looks great. Thanks for your care 👍