Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]tests: add tests for lock expiration #7777

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[tests-only][full-ci]tests: add tests for lock expiration #7777

merged 1 commit into from
Nov 22, 2023

Conversation

SwikritiT
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Nov 22, 2023
@SwikritiT SwikritiT mentioned this pull request Nov 22, 2023
Closed
7 tasks
@SwikritiT SwikritiT marked this pull request as ready for review November 22, 2023 06:46
@SwikritiT SwikritiT force-pushed the tests/add-tests-lock-expiration branch from 4b89b9d to 4cee9cd Compare November 22, 2023 09:00
grgprarup
grgprarup approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nabim777
Copy link
Member

LGTM

@SwikritiT SwikritiT merged commit 96862f4 into master Nov 22, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/add-tests-lock-expiration branch November 22, 2023 09:52
ownclouders pushed a commit that referenced this pull request Nov 22, 2023
@SwikritiT
tests: add tests for lock expiration (#7777)
11d6693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@nabim777 nabim777 nabim777 approved these changes

@grgprarup grgprarup grgprarup approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwikritiT @nabim777 @grgprarup @ScharfViktor