Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Last admin can remove himself #804

Closed
jnweiger opened this issue Nov 5, 2020 · 4 comments
Closed

[QA] Last admin can remove himself #804

jnweiger opened this issue Nov 5, 2020 · 4 comments
Labels
Category:Defect Existing functionality is not working as expected Interaction:Needs-Concept Type:Bug

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Nov 5, 2020

Seen on v1.0.0-rc3 created with hetzner-deploy/make_ocis_eos_compose_test.sh (and earlier in v1.0.0-rc1 in #530 (comment))

Log in as moss,

  • click on the 3x3 grid, then 'Accounts'
  • in the ROLE column, change all 'Admin' to 'User' (normally there is only one such entry for moss himself).
  • logout
  • log in as moss

The system is now without admin user. Moss can no longer go to the Accounts page.

Expected behaviour: Removing the last admin should not be possible. An error message appears, when trying.

@settings settings bot removed the bug label Jan 12, 2021
@refs refs added Category:Defect Existing functionality is not working as expected Interaction:Needs-Concept labels Jan 13, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@micbar
Copy link
Contributor

micbar commented May 10, 2022

Accounts service was removed. Does this also work for LibreIDM? @rhafer

@kulmann
Copy link
Member

kulmann commented May 10, 2022

Role assignments were never part of the accounts service. The described behaviour is still valid for the settings service (which currently is responsible for role assignments). The user-management app in web also doesn't prevent it.

@rhafer
Copy link
Contributor

rhafer commented May 11, 2022

Currently the Graph API would allow for an admin to delete himself from the user database. So apart from fixing the Role Assignment to disallow the last admin removing it's assignment. I think we should also prevent admins to delete their own account via glauth.

@micbar
Copy link
Contributor

micbar commented May 11, 2022

Duplicate of #3713 Closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Interaction:Needs-Concept Type:Bug
Projects
Archived in project
Development

No branches or pull requests

5 participants