Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Accounts page does not finish loading #530

Closed
jnweiger opened this issue Sep 8, 2020 · 8 comments
Closed

[QA] Accounts page does not finish loading #530

jnweiger opened this issue Sep 8, 2020 · 8 comments
Labels

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Sep 8, 2020

Seen with docker run --rm -ti -p 9200:9200 owncloud/ocis:1.0.0-rc1 and
ocis-1.0.0-rc1 via https://github.com/owncloud-docker/compose-playground/blob/master/examples/hetzner-deploy/make_ocis_eos_compose_test.sh

An ever loading blue bar is shown.
image

Log snippet when visiting the URL with shift reload:

2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:48162 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=158178 traceid=24a27b48dbbb93f42349f8e65d1be2d7 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:48162 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=124349 traceid=358403726f250b74e1a5b4d3ffafafd4 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:33376 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=284393 traceid=24a27b48dbbb93f42349f8e65d1be2d7 uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:33376 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=288848 traceid=358403726f250b74e1a5b4d3ffafafd4 uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:47378 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=1643130 traceid=24a27b48dbbb93f42349f8e65d1be2d7 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:47378 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=1767084 traceid=358403726f250b74e1a5b4d3ffafafd4 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF access token is already provided pkg=rhttp service=reva traceid=964afd5b12d2c4945c714f4db65dce33
2020-09-08T13:23:14Z INF http end="08/Sep/2020:13:23:14 +0000" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=reva size=2405 start="08/Sep/2020:13:23:14 +0000" status=200 time_ns=185687 traceid=964afd5b12d2c4945c714f4db65dce33 uri=/remote.php/dav/avatars/4c510ada-c86b-4815-8820-42cdf82c3d51/128.png url=/remote.php/dav/avatars/4c510ada-c86b-4815-8820-42cdf82c3d51/128.png
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:48162 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=103780 traceid=aee825025a3141872bd4f8e3c3f77f12 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:33376 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=228899 traceid=aee825025a3141872bd4f8e3c3f77f12 uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:47378 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=1040687 traceid=aee825025a3141872bd4f8e3c3f77f12 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF access token is already provided pkg=rhttp service=reva traceid=5256f8d436b4efcd321ef03e483e7a43
2020-09-08T13:23:14Z INF http end="08/Sep/2020:13:23:14 +0000" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=reva size=1519 start="08/Sep/2020:13:23:14 +0000" status=200 time_ns=174974 traceid=5256f8d436b4efcd321ef03e483e7a43 uri=/ocs/v1.php/cloud/capabilities?format=json url=/ocs/v1.php/cloud/capabilities?format=json
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:48162 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=119902 traceid=093938ac62de4405f47871b25f08536c uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:33376 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=287396 traceid=093938ac62de4405f47871b25f08536c uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:47378 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=1277333 traceid=093938ac62de4405f47871b25f08536c uri=/cs3.gateway.v1beta1.GatewayAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF access token is already provided pkg=rhttp service=reva traceid=358392e1172b5124f9dc6d665e1f162e
2020-09-08T13:23:14Z INF http end="08/Sep/2020:13:23:14 +0000" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=reva size=1519 start="08/Sep/2020:13:23:14 +0000" status=200 time_ns=168705 traceid=358392e1172b5124f9dc6d665e1f162e uri=/ocs/v1.php/cloud/capabilities?format=json url=/ocs/v1.php/cloud/capabilities?format=json
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:48162 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=120938 traceid=a4c54a271866f93fe870c12c09dceeb8 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:33376 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=272749 traceid=a4c54a271866f93fe870c12c09dceeb8 uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:47378 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=1159543 traceid=a4c54a271866f93fe870c12c09dceeb8 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z ERR listing groups for user count=4 service=ocs userid=4c510ada-c86b-4815-8820-42cdf82c3d51
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:48162 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=133900 traceid=fa8203a3bb0b1374399f62096b60dcf2 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:33376 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=265792 traceid=fa8203a3bb0b1374399f62096b60dcf2 uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:47378 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=1154385 traceid=fa8203a3bb0b1374399f62096b60dcf2 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF access token is already provided pkg=rhttp service=reva traceid=19689e54d7776a97a62535211515daf0
2020-09-08T13:23:14Z INF http end="08/Sep/2020:13:23:14 +0000" host=127.0.0.1 method=GET pkg=rhttp proto=HTTP/1.1 service=reva size=0 start="08/Sep/2020:13:23:14 +0000" status=200 time_ns=127705 traceid=19689e54d7776a97a62535211515daf0 uri=/ocs/v2.php/apps/notifications/api/v1/notifications?format=json url=/ocs/v2.php/apps/notifications/api/v1/notifications?format=json
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:48162 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=147442 traceid=b718beb52397eb42e6f38ca98bb53213 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:33376 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=390485 traceid=b718beb52397eb42e6f38ca98bb53213 uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateHome user-agent=grpc-go/1.26.0
2020-09-08T13:23:14Z INF unary code=OK end="08/Sep/2020:13:23:14 +0000" from=tcp://127.0.0.1:47378 pkg=rgrpc service=reva start="08/Sep/2020:13:23:14 +0000" time_ns=1673892 traceid=b718beb52397eb42e6f38ca98bb53213 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateHome user-agent=grpc-go/1.26.0
@jnweiger jnweiger added the qa label Sep 8, 2020
@jnweiger jnweiger changed the title Accounts page does not finish loading [QA] Accounts page does not finish loading Sep 8, 2020
@kulmann
Copy link
Member

kulmann commented Sep 8, 2020

This is a known issue, but since we don't have a changelog for ocis, it is not visible. https://github.com/owncloud/ocis/blob/master/changelog/unreleased/permission-checks-in-ocis-accounts.md

@kulmann
Copy link
Member

kulmann commented Sep 8, 2020

We decided to rather have this visually broken state and have permission checks on the accounts API endpoints, instead of not having permission checks and the accounts UI accessible for any user.

There are plans for hiding the accounts UI for users that don't have account management permissions. It is a stretch goal of the current sprint and tracked in this ticket: owncloud/product#167

@jnweiger
Copy link
Contributor Author

jnweiger commented Sep 10, 2020

Account page loads fine for admin user moss. But is readonly.

@kulmann
Copy link
Member

kulmann commented Sep 10, 2020

Account page loads fine for admin user moss. But is readonly.

The role assignment should work already.

Features for enabling and disabling users as well as deleting and creating users are part of the current sprint (already implemented, currently bubbling up into ocis).

@davitol
Copy link
Contributor

davitol commented Sep 11, 2020

Works for me with latest instance deployed

Screenshot 2020-09-11 at 10 24 37

@davitol
Copy link
Contributor

davitol commented Sep 11, 2020

Behavior from the open post keeps happening when user is not an admin user, so i guess we should do:

1 - Do not show accounts section (button) for non-admin users
2 - Do not allow admin user to revoke it's own role (we should avoid leaving an instance without admin)

@settings settings bot removed the qa label Sep 23, 2020
@jnweiger
Copy link
Contributor Author

jnweiger commented Nov 5, 2020

Retested in 1.0.0-rc3

Fixed:

  • admin can disable user, the user cannot log in, admin can reenable user, the user can again log in.
  • Non-admin users get a nice
    image

@jnweiger
Copy link
Contributor Author

jnweiger commented Nov 5, 2020

Closing here as the main issue is fixed. Thanks! The remaining part is in #804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants