Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocis-phoenix uses hardcoded https://localhost:9200 for external app configs #218

Closed
exalate-issue-sync bot opened this issue Sep 10, 2020 · 3 comments · Fixed by owncloud/ocis-phoenix#83
Labels
bug Something isn't working p3-medium Type:Bug

Comments

@exalate-issue-sync
Copy link

There is a flag PHOENIX_WEB_CONFIG_SERVER in ocis-phoenix which contains the public facing URL of the hosting. We need to use that URL in the default ExternalApps configs in pkg/service/v0/service.go instead of the hardcoded https://localhost:9200.

@exalate-issue-sync exalate-issue-sync bot added bug Something isn't working Exalated This issue is under sync p3-medium labels Sep 10, 2020
@exalate-issue-sync
Copy link
Author

Juergen Weigert commented: This might be the cause of owncloud/ocis#530 ?

https://95.217.182.248:9200/config.json as seen in my ocis-1.0.0-rc1 setup:

{
  "server": "https://95.217.182.248:9200",
  "theme": "owncloud",
  "version": "0.1.0",
  "openIdConnect": {
    "metadata_url": "https://95.217.182.248:9200/.well-known/openid-configuration",
    "authority": "https://95.217.182.248:9200",
    "client_id": "phoenix",
    "response_type": "code",
    "scope": "openid profile email"
  },
  "apps": [
    "files",
    "draw-io",
    "pdf-viewer",
    "markdown-editor",
    "media-viewer"
  ],
  "external_apps": [
    {
      "id": "accounts",
      "path": "https://localhost:9200/accounts.js"
    },
    {
      "id": "settings",
      "path": "https://localhost:9200/settings.js"
    }
  ],
  "options": {
    "hideSearchBar": true
  }
}

@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: [~jw] not the reason for the other issue. The issue you linked here already has the explanation for the loading bar in the comments.

@exalate-issue-sync
Copy link
Author

Remote key is https://jira.owncloud.com/browse/OCIS-489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p3-medium Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants